Fix assumptions about int64_t in MediaResourceServer

RESOLVED FIXED in mozilla33

Status

()

Core
WebRTC
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jld, Assigned: jld)

Tracking

unspecified
mozilla33
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
int64_t isn't necessarily long long int; on x86_64 Linux it's long int, and even though long long int is also 64 bits, the two types are treated as distinct by the C/C++ compiler.

This is currently breaking the --enable-media-plugins build, because a call to std::max in content/media/plugins/MediaResourceServer.cpp fails to unify.

Also, there are some misuses of "%lld" to printf an int64_t in the same file, but those are only warnings (despite --enable-warnings-as-errors).
(Assignee)

Comment 1

4 years ago
Created attachment 8443186 [details] [diff] [review]
bug1027953-gmp-64bit.diff

Trying: https://tbpl.mozilla.org/?tree=Try&rev=cae982acb686

Note that some of the whitespace is significant: "%"PRId64 is *not* the same as "%" PRId64 in C++11.

Also, I'm not sure if this is the right component or the right reviewer; [[Modules/All]] is not maximally helpful for this file.
Attachment #8443186 - Flags: review?(rjesup)
(Assignee)

Updated

4 years ago
See Also: → bug 911542
Comment on attachment 8443186 [details] [diff] [review]
bug1027953-gmp-64bit.diff

Review of attachment 8443186 [details] [diff] [review]:
-----------------------------------------------------------------

-> cpearce; I have no contact with MediaResourceServer
Attachment #8443186 - Flags: review?(rjesup) → review?(cpearce)
Attachment #8443186 - Flags: review?(cpearce) → review+
(Assignee)

Comment 3

4 years ago
c-n note: This is currently NPOTB on desktop, and that probably explains why the Try run in comment #1 has Windows builds busted in code I didn't touch, but here's another run if more assurance is desired: https://tbpl.mozilla.org/?tree=Try&rev=8439a57db1c6
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/5bfbe2cc3247
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.