1027979 - Remove more dead code from keyboard app

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

isContinousSpacePressed and showPendingSymbols are not used anymore.

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

I am going to remove isContinousSpacePressed in bug 1029356. This bug to be keep for removing |showPendingSymbols| in render.js.

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: WIP

Actually... Rudy, can you verify this WIP and submit a pull request?

I think it's faster this way.

Comment 3

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Sure. I'll have a check.

Comment 4

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: Patch V1

Will set review after the CI all pass.

Comment 5

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8451234 [details] [review]
Patch V1

I think this is ready to review because the Gaia UI Test failure is irrelevant.

Tim, could you please help on this?
Thank you.

Comment 6

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Landed to Gaia master,
https://github.com/mozilla-b2g/gaia/commit/d101974c43366020a91b86d1fd42713fe88d9e48

Thanks for the review.