Closed Bug 1027993 Opened 6 years ago Closed 6 years ago

Remove plstr.h usages under xpfe/

Categories

(Core :: General, defect)

x86
Windows 8.1
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: m_kato, Assigned: m_kato)

Details

Attachments

(1 file)

I think no reason to keep using PL_strstr in Gecko code.  We can use strstr instead.  Some libc such as glibc has SSE2 optimize version of strstr.

Also, we can remove nsCRT.h reference after removing it.
need null check for parameter.  Also we can remove #include "nsCRT.h" for this.
Attachment #8443232 - Flags: review?(neil)
Comment on attachment 8443232 [details] [diff] [review]
Replace PL_strstr with strstr

>+  bool viewSource = aContentType ? !!strstr(aContentType, "view-source") : false;
Why not write aContentType && strstr(aContentType, "view-source") (with extra !!s if you like)?
Attachment #8443232 - Flags: review?(neil) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/a5a361e955d1 with neil's comment
Target Milestone: --- → mozilla33
https://hg.mozilla.org/mozilla-central/rev/a5a361e955d1
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.