1027993 - Remove plstr.h usages under xpfe/

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Makoto Kato [:m_kato]]

I think no reason to keep using PL_strstr in Gecko code.  We can use strstr instead.  Some libc such as glibc has SSE2 optimize version of strstr.

Also, we can remove nsCRT.h reference after removing it.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Replace PL_strstr with strstr

need null check for parameter.  Also we can remove #include "nsCRT.h" for this.

Comment 2

[[e-mail]]

Comment on attachment 8443232 [details] [diff] [review]
Replace PL_strstr with strstr

>+  bool viewSource = aContentType ? !!strstr(aContentType, "view-source") : false;
Why not write aContentType && strstr(aContentType, "view-source") (with extra !!s if you like)?

Comment 3

[Makoto Kato [:m_kato]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a5a361e955d1 with neil's comment

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a5a361e955d1