Closed Bug 1028014 Opened 8 years ago Closed 8 years ago

webide should be named webide, not app manager

Categories

(DevTools Graveyard :: WebIDE, defect)

x86_64
All
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 33

People

(Reporter: paul, Assigned: paul)

Details

Attachments

(1 file)

It's been decided that App Manager V2 should be named "WebIDE".
Attached patch v1Splinter Review
Assignee: nobody → paul
Status: NEW → ASSIGNED
Attachment #8443295 - Flags: review?(dcamp)
Comment on attachment 8443295 [details] [diff] [review]
v1

Review of attachment 8443295 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/webide/locales/en-US/webide.properties
@@ +2,5 @@
>  # License, v. 2.0. If a copy of the MPL was not distributed with this
>  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
>  
> +title_noApp=Firefox WebIDE
> +title_app=Firefox WebIDE: %S

You're supposed to bump these string names when the string changes, no?
(In reply to Dave Camp (:dcamp) from comment #3)
> Comment on attachment 8443295 [details] [diff] [review]
> v1
> 
> Review of attachment 8443295 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: browser/devtools/webide/locales/en-US/webide.properties
> @@ +2,5 @@
> >  # License, v. 2.0. If a copy of the MPL was not distributed with this
> >  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
> >  
> > +title_noApp=Firefox WebIDE
> > +title_app=Firefox WebIDE: %S
> 
> You're supposed to bump these string names when the string changes, no?

l10n is temporarily disabled for WebIDE (see bug 1011464) until it's closer to being done, so it's safe to do this at the moment.
Attachment #8443295 - Flags: review?(dcamp) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/7e72de243a5a
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 33
Verified as fixed using latest Aurora 33.0a2 20140901004002 under Win 7 64-bit, Ubuntu 12.10 32-bit and Mac OSX 10.8.5. The menu options and the window's name are changed to WebIDE.
Status: RESOLVED → VERIFIED
QA Whiteboard: [qa+] → [qa!]
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.