Open Bug 1028129 Opened 5 years ago Updated 2 years ago
[mozcrash] Make mozcrash
.check _for _crashes() test _name mandatory
At the moment it's optional as to whether we pass in the test name to mozcrash.check_for_crashes(), so that it can use it in the PROCESS CRASH failure message: http://mxr.mozilla.org/mozilla-central/source/testing/mozbase/mozcrash/mozcrash/mozcrash.py#22 If not passed in, we just use the filename of the calling script, which normally isn't very helpful, since the calling script has much more context to make decisions like calling the test name "B2G Startup", "Shutdown" etc, even if there isn't a valid test running at the moment. As such, I think we should remove this footgun, to prevent having to play whac-a-mole with bugs like bug 1027607. Ideally we'd also call it something other than test-name, eg: step_name / description etc, but that will mean changing a lot of callers in lots of different repos, so let's save that for another day.
This still seems relevant/useful fwiw.
You need to log in before you can comment on or make changes to this bug.