1028137 - Build failure with --enable-default-toolkit=cairo-gtk3 and --disable-unified-compilation

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Mike Hommey [:glandium]]

/builds/slave/try-lx-d-000000000000000000000/build/toolkit/xre/nsGDKErrorHandler.cpp:28:46: error: 'strstr' was not declared in this scope
/builds/slave/try-lx-d-000000000000000000000/build/toolkit/xre/nsGDKErrorHandler.cpp:30:5: error: 'nsDependentCString' was not declared in this scope
/builds/slave/try-lx-d-000000000000000000000/build/toolkit/xre/nsGDKErrorHandler.cpp:30:24: error: expected ';' before 'buffer'
/builds/slave/try-lx-d-000000000000000000000/build/toolkit/xre/nsGDKErrorHandler.cpp:36:30: error: 'serialString' was not declared in this scope
/builds/slave/try-lx-d-000000000000000000000/build/toolkit/xre/nsGDKErrorHandler.cpp:36:63: error: 'NS_NAMED_LITERAL_CSTRING' was not declared in this scope
/builds/slave/try-lx-d-000000000000000000000/build/toolkit/xre/nsGDKErrorHandler.cpp:37:21: error: 'buffer' was not declared in this scope
/builds/slave/try-lx-d-000000000000000000000/build/toolkit/xre/nsGDKErrorHandler.cpp:38:18: error: 'kNotFound' was not declared in this scope
/builds/slave/try-lx-d-000000000000000000000/build/toolkit/xre/nsGDKErrorHandler.cpp:39:30: error: 'NS_RUNTIMEABORT' was not declared in this scope
/builds/slave/try-lx-d-000000000000000000000/build/toolkit/xre/nsGDKErrorHandler.cpp:43:69: error: 'strtol' was not declared in this scope
/builds/slave/try-lx-d-000000000000000000000/build/toolkit/xre/nsGDKErrorHandler.cpp:45:30: error: 'NS_RUNTIMEABORT' was not declared in this scope
/builds/slave/try-lx-d-000000000000000000000/build/toolkit/xre/nsGDKErrorHandler.cpp:47:30: error: 'errorCodeString' was not declared in this scope
/builds/slave/try-lx-d-000000000000000000000/build/toolkit/xre/nsGDKErrorHandler.cpp:48:64: error: 'Substring' was not declared in this scope
/builds/slave/try-lx-d-000000000000000000000/build/toolkit/xre/nsGDKErrorHandler.cpp:48:82: error: 'StringBeginsWith' was not declared in this scope
/builds/slave/try-lx-d-000000000000000000000/build/toolkit/xre/nsGDKErrorHandler.cpp:49:30: error: 'NS_RUNTIMEABORT' was not declared in this scope
/builds/slave/try-lx-d-000000000000000000000/build/toolkit/xre/nsGDKErrorHandler.cpp:54:30: error: 'NS_RUNTIMEABORT' was not declared in this scope
/builds/slave/try-lx-d-000000000000000000000/build/toolkit/xre/nsGDKErrorHandler.cpp:56:30: error: 'requestCodeString' was not declared in this scope
/builds/slave/try-lx-d-000000000000000000000/build/toolkit/xre/nsGDKErrorHandler.cpp:57:64: error: 'Substring' was not declared in this scope
/builds/slave/try-lx-d-000000000000000000000/build/toolkit/xre/nsGDKErrorHandler.cpp:57:84: error: 'StringBeginsWith' was not declared in this scope
/builds/slave/try-lx-d-000000000000000000000/build/toolkit/xre/nsGDKErrorHandler.cpp:58:30: error: 'NS_RUNTIMEABORT' was not declared in this scope
/builds/slave/try-lx-d-000000000000000000000/build/toolkit/xre/nsGDKErrorHandler.cpp:63:30: error: 'NS_RUNTIMEABORT' was not declared in this scope
/builds/slave/try-lx-d-000000000000000000000/build/toolkit/xre/nsGDKErrorHandler.cpp:65:30: error: 'minorCodeString' was not declared in this scope
/builds/slave/try-lx-d-000000000000000000000/build/toolkit/xre/nsGDKErrorHandler.cpp:68:30: error: 'NS_RUNTIMEABORT' was not declared in this scope
/builds/slave/try-lx-d-000000000000000000000/build/toolkit/xre/nsGDKErrorHandler.cpp:73:30: error: 'NS_RUNTIMEABORT' was not declared in this scope
/builds/slave/try-lx-d-000000000000000000000/build/toolkit/xre/nsGDKErrorHandler.cpp:82:28: error: 'NS_RUNTIMEABORT' was not declared in this scope

Comment 1

[Mike Hommey [:glandium]]

Attachment: Add missing headers in toolkit/xre/nsGDKErrorHandler.cpp

This should be enough. Try will tell for sure.
https://tbpl.mozilla.org/?tree=Try&rev=2a635cf6c78d

Comment 2

[Mike Hommey [:glandium]]

(In reply to Mike Hommey [:glandium] from comment #1)
> Try will tell for sure.
> https://tbpl.mozilla.org/?tree=Try&rev=2a635cf6c78d

Note the linux debug build is non-unified.

Comment 3

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4413df3a4694

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/4413df3a4694