1028141 - Remove dangerous public destructor of CSF::AudioControl

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect)

Description

[Benoit Jacob [:bjacob] (mostly away)]

In bug 1027251 we removed all dangerous public destructors of XPCOM-refcounted classes outside of a finite whitelist, see HasDangerousPublicDestructor. Now we are going over the entries in this whitelist.

One of them is: CSF::AudioControl

Comment 1

[Andrew McCreight [:mccr8]]

It seems weird that AudioControlWrapper both inherits from AudioControl, and has a pointer to an instance of AudioControl, but ok.

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: Remove dangerous public destructor of CSF::AudioControl.

try: https://tbpl.mozilla.org/?tree=Try&rev=daa327c18c40

Comment 3

[Adam Roach [:abr]]

(In reply to Andrew McCreight [:mccr8] from comment #1)
> It seems weird that AudioControlWrapper both inherits from AudioControl, and
> has a pointer to an instance of AudioControl, but ok.

Those teeth were like that when we were gifted this horse... :)

Comment 4

[Adam Roach [:abr]]

Comment on attachment 8464354 [details] [diff] [review]
Remove dangerous public destructor of CSF::AudioControl.

Review of attachment 8464354 [details] [diff] [review]:
-----------------------------------------------------------------

looks fine.

Comment 5

[Andrew McCreight [:mccr8]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/920b946b4380

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/920b946b4380