Closed Bug 1028159 Opened 10 years ago Closed 10 years ago

[v2.1] test_edit_contact failure

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: AndreiH, Assigned: zcampbell)

Details

Attachments

(1 file, 1 obsolete file)

46 bytes, text/x-github-pull-request
AndreiH
: review+
Details | Review
Traceback:

05:40:16 Traceback (most recent call last):
05:40:16   File "/var/jenkins/workspace/b2g.flame.mozilla-central.ui.smoketest/.env/local/lib/python2.7/site-packages/marionette_client-0.7.9-py2.7.egg/marionette/marionette_test.py", line 170, in run
05:40:16     testMethod()
05:40:16   File "/var/jenkins/workspace/b2g.flame.mozilla-central.ui.smoketest/tests/python/gaia-ui-tests/gaiatest/tests/functional/contacts/test_edit_contact.py", line 42, in test_edit_contact
05:40:16     edit_contact.type_family_name(self.contact['familyName'])
05:40:16   File "/var/jenkins/workspace/b2g.flame.mozilla-central.ui.smoketest/tests/python/gaia-ui-tests/gaiatest/apps/contacts/regions/contact_form.py", line 43, in type_family_name
05:40:16     self.keyboard.dismiss()
05:40:16   File "/var/jenkins/workspace/b2g.flame.mozilla-central.ui.smoketest/tests/python/gaia-ui-tests/gaiatest/apps/keyboard/app.py", line 338, in dismiss
05:40:16     %(keyboards.is_displayed(), keyboards.get_attribute('class')))
05:40:16   File "/var/jenkins/workspace/b2g.flame.mozilla-central.ui.smoketest/.env/local/lib/python2.7/site-packages/marionette_client-0.7.9-py2.7.egg/marionette/wait.py", line 143, in until
05:40:16     cause=last_exc)
05:40:16 TEST-UNEXPECTED-FAIL | test_edit_contact.py test_edit_contact.TestContacts.test_edit_contact | TimeoutException: TimeoutException: Timed out after 20.0 seconds with message: Keyboard was not dismissed. Debug is_displayed(): True, class: .


What is happening here is that we dismiss the keyboard and then use it again at the next step, maybe it doesn't has time to completely disappear.

I don't see any reason why we should have that dismiss there.

https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/apps/contacts/regions/contact_form.py#L39
Attachment #8443447 - Flags: review?(zcampbell)
I am closing this bug, that dismiss was added there for a reason.
I couldn't replicate this locally, this was a 1 time fail.
If we remove that dismiss we will cause other failures.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → INVALID
If we see this fail again we will investigate and add another solution.
Attachment #8443447 - Flags: review?(zcampbell)
Assignee: nobody → zcampbell
Attached file github pr
AndreiH, not sure what problems you struck but this works Ok for me
Attachment #8443447 - Attachment is obsolete: true
Attachment #8444469 - Flags: review?(andrei.hutusoru)
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Comment on attachment 8444469 [details] [review]
github pr

Works great!

Merged:
https://github.com/mozilla-b2g/gaia/commit/621de52d53ffbbcd7c50ff127d723f99e21b1bcb
Attachment #8444469 - Flags: review?(andrei.hutusoru) → review+
Status: REOPENED → RESOLVED
Closed: 10 years ago10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: