Closed Bug 1028163 Opened 10 years ago Closed 10 years ago

Review + Deploy ThunderHug

Categories

(Webmaker Graveyard :: Events, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: fuzzyfox, Unassigned)

References

()

Details

(Whiteboard: [mozfest])

Attachments

(2 files)

ThunderHug is a small server that sits between Google Docs + the MozFest website to reformat input data, strip out email addresses + any other information indicated to be private.

It also provides meta information on the number of requests, what themes/tracks there are, and sessions associated to tracks.

ToDo:

- code review of server
- transfer repo to mozilla on github
- deploy server somewhere (designed to work on heroku)
Attachment #8443450 - Flags: review?
Small note on the config that you can use your @mozillafoundation.org google account for testing ;)
Attachment #8443450 - Flags: review? → review?(jon)
Attachment #8443501 - Flags: review?(jon)
Comment on attachment 8443450 [details]
config.json file for ThunderHug

woops set flag on wrong thing
Attachment #8443450 - Flags: review?(jon)
Comment on attachment 8443501 [details]
http://github.com/fuzzyfox/thunderhug

I think I saw that this is already deployed, so consider this a list of issues to look at fixing up when you get a chance. Shipping code is better than no code!

/bin/getProposals:
- What is this for? It looks like the thing that takes data from the spreadsheet and stuffs it into Redis. If it's required, you should add documentation stating that, how to run it, etc
- Instead of using the title as a redis key, maybe using the row id as a redis key? title could be duplicated, right?

/bin/index.js:
- Instead of forking getProposals, you should have a js lib can be called as a library for that use, or bu getProposals

Procfile:
- Where is your Procfile? You should have one for Heroku deployment

README.md:
- How do I clone thunderhug? Might as well add `git clone https://github.com/fuzzyfox/thunderhug.git` and `cd thunderhug`
- Spacing looks weird inside the Configure code block
- I don't see a way to configure what redis server I'm using
- The default config doesn't have a working spreadsheet key, and it'd be nice to see a working spreadsheet, or have some sort of spreadsheet I can fork to have a working server
- Add JSON formatting to the api call code blocks
- If I was doing it from scratch, I'd call the API http methods something like /sessions and /sessions/:theme, and /themes
- I feel like the Heroku deployment section is missing stuff like adding Redis plugin and such to my own Heroku instance

server.js:
- Forking a process with no callback in my http server? D:
- No caching at all? D:
- I don't think you need to check for json vs jsonp format with the res.jsonp() call
- CSV? D: If you want it, you could use http://expressjs.com/4x/api.html#res.format for no switch statements


shared.js:
- Exporting the env and redis client inside a shared file makes testing more difficult. Only your bootstrapping file should do config parsing; everything else should accept a plain Object
- You could replace the debug function with https://www.npmjs.org/package/debug
- This entire file should just go away
Attachment #8443501 - Flags: review?(jon) → review+
As far as I know its not actually deployed anywhere. (FireHug is however).


Will turn those issues you've highlighted into items in GH for tracking + resolution. Moving onto the next step of making this live somewhere. What makes the most sense for the domain + who should own the heroku app?

I'm thinking something like proposals.mozillafestival.org (as Thunder deals w/ proposals and Fire deals w/ schedule and is hosted at schedule.mozfest)
Additional thing I'm going to drop here rather than new bug as its completely related. Could I get permission on mozilla/thunderhug now the repo is transferred. Thanks :)
Can we move this out of the Events component? Unless I'm missing something, it doesn't seem to relate to the Events app. Thanks!
Flags: needinfo?(williamd)
Hey Gavin, I dropped it in here as this component's description indicated its scope includes MozFest stuff... happy to move it to a better match if you know where that might be.
Flags: needinfo?(williamd)
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: