1028190 - Allow MockContact properties to be None

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect, P3)

Description

[Zac C (:zac)]

When we initialise a MockContact, we should be able to pass in None for a property and in turn have that property not set.

For example, currently if we want a Contact without an email address, passing in " email = None " causes the email address to be zero length string, rather than no email address present.

Comment 1

[Gonzalo Martinez]

Hello! How i can start with this? THis behavior is needed for all the properties?
"givenName, familyName, name, email, tel, adr, note"

Comment 2

[Zac C (:zac)]

Yes, all properties!

I've assigned you to the task. Ping us here or in #mozwebqa if you need some more help.

Cheers

Comment 3

[Florin Strugariu [:Bebe]]

Gonzalo Martinez do you need help with the task?

Comment 4

[Gonzalo Martinez]

Yes please, i need know how start, or where is the code? i think that is this https://github.com/mozilla-b2g/gaia but i need confirm what is the procedure to resolve. If i make a Push to git repo directly or how i start with this.
Thanks a lot!

Comment 5

[Florin Strugariu [:Bebe]]

you are right the code is in  https://github.com/mozilla-b2g/gaia

To be more exact you are interested in: https://github.com/mozilla-b2g/gaia/tree/master/tests/python/gaia-ui-tests this is our tests dir.

To get your code in you need first to make a "Fork" of the gaia repo; commit your code in a separate branch in your fork and then submit a pull request for review 

Make sure you add the pull to this bug and submit a review request to us

Comment 6

[Florin Strugariu [:Bebe]]

you can find the MockContact code in 
 https://github.com/mozilla-b2g/gaia/tree/master/tests/python/gaia-ui-tests/gaiatest/mocks

Comment 7

[Gonzalo Martinez]

Thanks i am downloading the code from my fork. Soon i resolve this! Thanks

Comment 8

[Gonzalo Martinez]

I make my pull requests. I am Happy
https://github.com/mozilla-b2g/gaia/pull/21455
Thanks for all!

Comment 9

[Florin Strugariu [:Bebe]]

Attachment: Pull request

I added a pull request attachment to the bug and asked for reviews

Comment 10

[Florin Strugariu [:Bebe]]

Comment on attachment 8452210 [details] [review]
Pull request

Can you update the commit message pls

Comment 11

[Zac C (:zac)]

Comment on attachment 8452210 [details] [review]
Pull request

It works well, thanks!

r+, but as Bebe suggested you just need to update the commit message and have just 1 commit in the pull request.

if you make the commit message " Bug 1028190 - Allow MockContact properties to be None" that is perfect!

Comment 12

[Gonzalo Martinez]

Here is the new commit message :D 
https://github.com/gonzafirewall/gaia/commit/1729c5d64594396909929358d675005971070e86
Sorry for late, but i dont touch my PC during yesterday!
Thanks i am happy to make my first contribution to the Mozilla community!
Y por que Argentina está en la final! Sorry :D

Comment 13

[Florin Strugariu [:Bebe]]

In your pull request you have 3 commits now :(((

Can you squash the commits to get one commit message with the "Bug 1028190 - Allow MockContact properties to be None" text

Comment 14

[Florin Strugariu [:Bebe]]

here is a simple way to do that:
http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html


GO Argentina!!!!

Comment 15

[Gonzalo Martinez]

Now take 2 but the merge commit :S i dont know how to resolve :S

Comment 16

[Zac C (:zac)]

I will pick just the correct commit Gonzalo.

Comment 17

[Zac C (:zac)]

Merged it directly:
https://github.com/mozilla-b2g/gaia/commit/33f386bacbb2654b9669e0f93470d02174e1226a

Thanks Gonzalo and good luck in the final ;)