1028237 - Video controls cut and flickering when fading away

Status: VERIFIED FIXED

(Core :: Audio/Video, defect)

Description

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

Reproducible on:
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Firefox/31.0
20140619131915
Mozilla/5.0 (X11; Linux x86_64; rv:32.0) Gecko/20100101 Firefox/32.0
20140619004025
Mozilla/5.0 (X11; Linux x86_64; rv:33.0) Gecko/20100101 Firefox/33.0
20140619030203

Steps to reproduce:
1. Launch Firefox with a clean profile.
2. Go to, for example https://air.mozilla.org/webrtc-meet-up-francophone-paris/.
3. Play the video. 
4. During playback hover the video are to get the video controls, then move the cursor outside the video area.

Expected results:
When the cursor is moved outside the video area, the video controls should fade away in a 2 sec animation.

Actual results:
When the cursor is moved outside the video area, the video controls are cut, as part disappears instantly, while part continues to flicker for about 2 seconds and then disappears.

Notes: 
1. The issue appeared after fix for bug 994282.
2. On Windows and Mac there are no issues, as the controls fade away in a 2 sec second animation.

Comment 1

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

Attachment: screenshot_31_beta3.png

Comment 2

[u279076]

Matt, since you landed the patch for bug 994282, could you please have a look at this?

Comment 3

[Matt Woodrow (:mattwoodrow)]

Attachment: Account for device offset for thebes layer masks

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8445596 [details] [diff] [review]
Account for device offset for thebes layer masks

Review of attachment 8445596 [details] [diff] [review]:
-----------------------------------------------------------------

r+ on the other part.

::: widget/cocoa/nsChildView.mm
@@ +3723,5 @@
>    nsAutoRetainCocoaObject kungFuDeathGrip(self);
>    bool painted = false;
>    if (mGeckoChild->GetLayerManager()->GetBackendType() == LayersBackend::LAYERS_BASIC) {
>      nsBaseWidget::AutoLayerManagerSetup
> +      setupLayerManager(mGeckoChild, targetContext, BufferMode::BUFFERED);

Is this change supposed to be part of this patch?

Comment 5

[Matt Woodrow (:mattwoodrow)]

(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #4)
> Comment on attachment 8445596 [details] [diff] [review]
> Account for device offset for thebes layer masks
> 
> Review of attachment 8445596 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r+ on the other part.
> 
> ::: widget/cocoa/nsChildView.mm
> @@ +3723,5 @@
> >    nsAutoRetainCocoaObject kungFuDeathGrip(self);
> >    bool painted = false;
> >    if (mGeckoChild->GetLayerManager()->GetBackendType() == LayersBackend::LAYERS_BASIC) {
> >      nsBaseWidget::AutoLayerManagerSetup
> > +      setupLayerManager(mGeckoChild, targetContext, BufferMode::BUFFERED);
> 
> Is this change supposed to be part of this patch?

Nope, accidental qref.

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Video matters now. Tracking.

Comment 7

[Matt Woodrow (:mattwoodrow)]

Attachment: Account for device offset for thebes layer masks v2

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f79302ac0ede

Comment 9

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

Verified as fixed on Ubuntu 13.04 x64 (User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:33.0) Gecko/20100101 Firefox/33.0) with latest Firefox 33 Nightly (BuildID: 20140702030201). The video controls now fade away in a 2 second animation as expected.

Comment 10

[u279076]

Given QA has verified this fixed it would be good to uplift this, if it's low risk.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2]]

When will this be uplifted? We are getting really close to the release, and there is risk we wont be able to land it for Firefox 31. :/ Matt, what blocks you here from backporting? See bug 1035114 for another graphical fallout, which this patch would fix.

Comment 12

[Sylvestre Ledru [:Sylvestre]]

Yeh, the patch seems low risk and have been in m-c for a week, I could take it in 31 in the RC.

Comment 13

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8447791 [details] [diff] [review]
Account for device offset for thebes layer masks v2

Approval Request Comment
[Feature/regressing bug #]: Bug 994282
[User impact if declined]: Broken mask layers, reported issue with video controls
[Describe test coverage new/current, TBPL]: Tested manually and verified.
[Risks and why]: Very low risk, just extends an earlier change to cover all layer types.
[String/UUID change made/needed]: None.

Comment 14

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8447791 [details] [diff] [review]
Account for device offset for thebes layer masks v2

Actually, I changed my mind for beta. I will however take for ESR 31.1.0

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/fe01ba854115

Comment 16

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Works great with Mozilla/5.0 (X11; Linux x86_64; rv:32.0) Gecko/20100101 Firefox/32.0 ID:20140715004003 CSet: d32649a24965. Thanks for the backport!

Comment 17

[Lukas Blakk [:lsblakk] use ?needinfo]

Without active requests from the ESR community, this does not meet ESR landing criteria.