Do final QA on welcome.webmaker.org snippet landing page

RESOLVED FIXED

Status

Webmaker
webmaker.org
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: OpenMatt, Assigned: andreawood)

Tracking

Details

(Whiteboard: [snippet] [june27])

Attachments

(1 attachment)

Comment hidden (empty)
(Reporter)

Updated

4 years ago
Whiteboard: [snippet] [june27]

Updated

4 years ago
Blocks: 1028287

Updated

4 years ago
Depends on: 1027045, 1027715
(Reporter)

Comment 1

4 years ago
* Andrea: can you do final QA?
Assignee: nobody → ali

Comment 3

4 years ago
Yep, that's the correct thanks tag.
Depends on: 1027724
Flags: needinfo?(jon)

Comment 4

4 years ago
Blargh. That's the correct thanks tag, and the email copy will be updated in bug 1027724.
Assignee: ali → nobody

Updated

4 years ago
Assignee: nobody → andrea
(Reporter)

Comment 5

4 years ago
* Andrea: you're going to do final QA on this page, with BSD helping right?
http://welcome.webmaker.org/

* Also: can you confirm that snippet traffic won't actually be turned on until Tuesday?
Flags: needinfo?(andrea)
(Reporter)

Comment 6

4 years ago
@ Andrea: can you provide final sign off and close this ticket when ready?

* Closing this ticket means: yes, we are 100% ready for the snippet.
(Assignee)

Comment 7

4 years ago
Hm, looks good! But there are a couple of issues:

-- The opt-in checkbox should have a "required" indication, like a red asterisk that is noted at bottom as "required". 

-- When I submitted my email, checked the box, and clicked "submit" I got this error: https://www.evernote.com/shard/s202/sh/f800aba7-3139-4632-9b2e-bca7d3634d50/cc74685c0d09b8f1b7d18b298f2b8a5a/deep/0/sendto.mozilla.org---snippet-test-and-Inbox-(20530-messages,-2853-unread).png

Maybe you're working on it?
Flags: needinfo?(andrea)

Comment 8

4 years ago
I fixed up the email submission errors, it was due to a style change we made on Friday that accidentally removed some required HTML attributes.

I'll make the required indication on the checkbox a bit larger
(Reporter)

Comment 9

4 years ago
Thanks Jbuck!
Comment on attachment 8444586 [details] [review]
https://github.com/mozilla/webmaker-snippet-landing-page/pull/6

Ignore the browser compatibility comments, since this is ff only
Attachment #8444586 - Flags: review?(kate) → review+
(Reporter)

Updated

4 years ago
Status: NEW → ASSIGNED

Updated

4 years ago
Depends on: 1029528
(Reporter)

Comment 13

4 years ago
* Are we ready to release the hounds?
Flags: needinfo?(jon)
ship it!
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Flags: needinfo?(jon)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.