10283 - [feature] [PP]Patch: Macintosh patching a text file fails with error -220

Status: VERIFIED WORKSFORME

(Core Graveyard :: Installer: XPInstall Engine, defect, P3)

Description

[Jimmy Lee]

Build: 7/20/99 SeaMonkey build

1. From http://jimbob/trigger2.html, enter or use drop-down to trigger
   a_addmacpatch.jar to add text file for patching
2. Then trigger a_macpatch.jar

NOTE:
This test used to work.  I don't know exactly which build it began to fail.

RESULT:
The file is added correctly.  After triggering a_macpatch.jar, the "macpatch"
directory ends up with two files, smrtupdt-1.txt and smrtupdt.txt.

The Install.log shows:
---------------------------------------------------------------------------
http://jimbob/jars/a_addmacpatch.jar     --     07/21/1999 11:19:14
---------------------------------------------------------------------------

     Acceptance: a_addmacpatch

     Item [1/1]	Installing: Webbies:moz720:macpatch:smrtupdt.txt

     Install completed successfully
     Finished Installation  07/21/1999 11:19:15

---------------------------------------------------------------------------
http://jimbob/jars/a_macpatch.jar     --     07/21/1999 11:20:01
---------------------------------------------------------------------------

     Acceptance: a_macpatch

     ** ERROR (-220): Patching: Webbies:moz720:macpatch:smrtupdt.txt

     Install script aborted
     Finished Installation  07/21/1999 11:20:01

EXPECTED RESULT:
No error message in Install.log.  Only one file remains in "macpatch" directory
after patching is applied.

Comment 1

[Cathleen]

I'll try to take a look at this bug.

Comment 2

[Cathleen]

Jimmy, can you check if smrtupdt.txt is indeed patched correctly?

If it is, then all we need to do is to clean up smrtupdt-1.txt (which is
the extracted patch data file), then this is a dup of bug 10297 and I have a fix
ready for it.

Comment 3

[Jimmy Lee]

Build 8/16/99

There has been a change.  The patching is now failing.  Instead of
"smrtupdt.txt", the result of patching is "smrtupdt_patch.txt.gdf".  Yes, I
compared the patch, and it is all that remains when patching is completed.
There is no file by "smrtupdt-1.txt" that remains.

The Install.log shows the following:

---------------------------------------------------------------------------
http://jimbob/jars/a_addmacpatch.jar     --     08/17/1999 16:05:53
---------------------------------------------------------------------------
Acceptance: a_addmacpatch

Item [1/1]Installing: Webbies:moz816:mozilla-mac-M9:macpatch:smrtupdt.txt
Install completed successfully
Finished Installation  08/17/1999 16:05:56

---------------------------------------------------------------------------
http://jimbob/jars/a_macpatch.jar     --     08/17/1999 16:07:32
---------------------------------------------------------------------------
Acceptance: a_macpatch

Item [1/1]Patching: Webbies:moz816:mozilla-mac-M9:macpatch:smrtupdt.txt
Install **FAILED** with error 6
Install **FAILED** with error 6
Finished Installation  08/17/1999 16:07:34

Comment 4

[Cathleen]

Jimmy, I can't seem to reproduce this problem on Don's Mac, so I'm marking this
as WORKSFORME.

Since you're seeing the file gets deleted, it may be due to the bug where we
fail to update registry file at the finalize stage (due to currupted registry
file).

Please try to see if you can still reproduce the problem first, and then rename
your old registry and created a new file from 4.6, and try to see if the problem
should go away.

Dan also checked in fix where if we do get registry update err at the end of
patching process, we will ignore the err and continue, and thus won't cause the
file gets deleted afterwards.  see bug 12242

Comment 5

[Jimmy Lee]

Build 9/7/99

Patching a text file works.  My netscape registry may have been corrupted since
I did create a new one to verify.

Comment 6

[leger]

Bulk move of XPInstall (component to be deleted) bugs to Installer: XPInstall
Engine

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d29c8b0330ea
[components] Closes https://github.com/mozilla-mobile/android-components/issues/10283: Update mobile specific Amazon search attribution codes
https://hg.mozilla.org/integration/autoland/rev/2d6086298b92
[components] Closes https://github.com/mozilla-mobile/android-components/issues/10283: Add region specific search engine lists for fr-CA, fr-FR and en-AU