Closed Bug 1028328 Opened 5 years ago Closed 5 years ago

set NSS_DISABLE_DBM in b2g's confvars.sh

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla33

People

(Reporter: froydnj, Assigned: froydnj)

References

Details

Attachments

(1 file)

set NSS_DISABLE_DBM in b2g's confvars.sh
588 bytes, patch
glandium
: review+
Details | Diff | Splinter Review 
No description provided.
We set NSS_DISABLE_DBM in configure for:

case "${target}" in
    *-android*|*-linuxandroid*)
        if test "$CPU_ARCH" = "arm" ; then
          USE_ARM_KUSER=1
        fi

        NSS_DISABLE_DBM=1
        ...

but we don't set it for, say, b2g desktop builds.  We should, if for no other
reason than to reduce variance between b2g device builds and b2g desktop
builds.
Attachment #8443612 - Flags: review?(mshal)
Green on try, too:

https://tbpl.mozilla.org/?tree=Try&rev=c0c84b915d14
Assignee: nobody → nfroyd
Blocks: 1025998
Comment on attachment 8443612 [details] [diff] [review]
set NSS_DISABLE_DBM in b2g's confvars.sh

Review of attachment 8443612 [details] [diff] [review]:
-----------------------------------------------------------------

See comment 1 for the details.
Attachment #8443612 - Flags: review?(mshal) → review?(mh+mozilla)
Attachment #8443612 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/e9724f9aed82
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.