Closed Bug 1028329 Opened 8 years ago Closed 8 years ago

[AccessFu] Cancel delayed vc automove if before explicit move

Categories

(Core :: Disability Access APIs, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: eeejay, Assigned: eeejay)

References

Details

Attachments

(1 file)

Say there is a focus change, or a new dialog appears. If there is an intentional delay before the move and the user interacts in any way, we should make sure the automove is canceled so that the user doesn't get thrown somewhere unexpected.
Blocks: 981363
Comment on attachment 8443613 [details] [diff] [review]
Cancel delayed automove if there is an explicit interaction by the user.

Review of attachment 8443613 [details] [diff] [review]:
-----------------------------------------------------------------

r=me. Looks good. Just one nit.

::: accessible/src/jsat/ContentControl.jsm
@@ +440,5 @@
>      }
>    },
>  
> +  cancelAutoMove: function cc_cancelAutoMove() {
> +    if (this._autoMove) {

No need to check for this._autoMove. Invalid timeout id has no effect.
Attachment #8443613 - Flags: review?(yzenevich) → review+
https://hg.mozilla.org/mozilla-central/rev/e3f4b2f97d53
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.