1028329 - [AccessFu] Cancel delayed vc automove if before explicit move

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Eitan Isaacson [:eeejay]]

Say there is a focus change, or a new dialog appears. If there is an intentional delay before the move and the user interacts in any way, we should make sure the automove is canceled so that the user doesn't get thrown somewhere unexpected.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Cancel delayed automove if there is an explicit interaction by the user.

Comment 2

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8443613 [details] [diff] [review]
Cancel delayed automove if there is an explicit interaction by the user.

Review of attachment 8443613 [details] [diff] [review]:
-----------------------------------------------------------------

r=me. Looks good. Just one nit.

::: accessible/src/jsat/ContentControl.jsm
@@ +440,5 @@
>      }
>    },
>  
> +  cancelAutoMove: function cc_cancelAutoMove() {
> +    if (this._autoMove) {

No need to check for this._autoMove. Invalid timeout id has no effect.

Comment 3

[Eitan Isaacson [:eeejay]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e3f4b2f97d53

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e3f4b2f97d53