1028337 - ClassCastException when closing all private tabs

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

1) Open tabs panel
2) Click private tabs panel
3) Hit hamburger button
4) Click "Close Private Tabs"

Expected: Close private tabs is probably disabled as there are no private tabs
Acutal: Crash!

Stack trace:

06-20 11:09:41.426 E/GeckoAppShell(14537): java.lang.ClassCastException: org.mozilla.gecko.tabspanel.PrivateTabsPanel cannot be cast to org.mozilla.gecko.tabspanel.TabsPanel$CloseAllPanelView
06-20 11:09:41.426 E/GeckoAppShell(14537):      at org.mozilla.gecko.tabspanel.TabsPanel.onMenuItemClick(TabsPanel.java:231)
06-20 11:09:41.426 E/GeckoAppShell(14537):      at org.mozilla.gecko.widget.GeckoPopupMenu.onMenuItemClick(GeckoPopupMenu.java:153)
06-20 11:09:41.426 E/GeckoAppShell(14537):      at org.mozilla.gecko.menu.GeckoMenu.handleMenuItemClick(GeckoMenu.java:575)
06-20 11:09:41.426 E/GeckoAppShell(14537):      at org.mozilla.gecko.menu.GeckoMenu.onItemClick(GeckoMenu.java:551)
06-20 11:09:41.426 E/GeckoAppShell(14537):      at android.widget.AdapterView.performItemClick(AdapterView.java:298)
06-20 11:09:41.426 E/GeckoAppShell(14537):      at android.widget.AbsListView.performItemClick(AbsListView.java:1100)
06-20 11:09:41.426 E/GeckoAppShell(14537):      at android.widget.AbsListView$PerformClick.run(AbsListView.java:2749)
06-20 11:09:41.426 E/GeckoAppShell(14537):      at android.widget.AbsListView$1.run(AbsListView.java:3423)

The same behavior occurs when a private tab is created:

06-20 11:18:59.488 E/GeckoAppShell(15087): java.lang.ClassCastException: org.mozilla.gecko.tabspanel.PrivateTabsPanel cannot be cast to org.mozilla.gecko.tabspanel.TabsPanel$CloseAllPanelView
06-20 11:18:59.488 E/GeckoAppShell(15087):      at org.mozilla.gecko.tabspanel.TabsPanel.onMenuItemClick(TabsPanel.java:231)
06-20 11:18:59.488 E/GeckoAppShell(15087):      at org.mozilla.gecko.widget.GeckoPopupMenu.onMenuItemClick(GeckoPopupMenu.java:153)
06-20 11:18:59.488 E/GeckoAppShell(15087):      at org.mozilla.gecko.menu.GeckoMenu.handleMenuItemClick(GeckoMenu.java:575)
06-20 11:18:59.488 E/GeckoAppShell(15087):      at org.mozilla.gecko.menu.GeckoMenu.onItemClick(GeckoMenu.java:551)
06-20 11:18:59.488 E/GeckoAppShell(15087):      at android.widget.AdapterView.performItemClick(AdapterView.java:298)
06-20 11:18:59.488 E/GeckoAppShell(15087):      at android.widget.AbsListView.performItemClick(AbsListView.java:1100)
06-20 11:18:59.488 E/GeckoAppShell(15087):      at android.widget.AbsListView$PerformClick.run(AbsListView.java:2749)
06-20 11:18:59.488 E/GeckoAppShell(15087):      at android.widget.AbsListView$1.run(AbsListView.java:3423)

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Fix crash when closing all private tabs.

I made CloseAllPanelView extend PanelView and cleaned that up while I was at it.

Comment 2

[:Margaret Leibovic]

Comment on attachment 8443691 [details] [diff] [review]
Fix crash when closing all private tabs.

Review of attachment 8443691 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, thanks for the patch. Looks like PrivateTabsPanel was added just before I landed my patch, so I didn't know about it!

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/78ffdbef077c

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/78ffdbef077c

Comment 6

[Teodora Vermesan (:TeoVermesan)]

"Close Private Tabs" now closes the private tabs opened, so verified fixed on:
Device: Samsung Galaxy Nexus (Android 4.2.1)
Build: Firefox for Android 33.0a1 (2014-06-25)