1028351 - [Vertical] "Vertical" App name should be localized

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Théo Chevalier]

Attachment: Screenshot on 2.0, French

See the attached screenshot, the App name is currently not localized.

We should either:
- Add it to the localized manifest file
- Remove all the occurrences from the UI

If we choose to localize it, we need the strings to be landed by the end of the day on 2.0.

Comment 1

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Theo - Will this do the trick? We're a bit short on reviewers, so if it looks good to you, your R+ stamp would be appreciated.

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8443661 [details] [review]
Github pull request

Or maybe you could take a look at this James if Theo can't get to it? Json hard.

Comment 3

[James Lal [:lightsofapollo]]

Comment on attachment 8443661 [details] [review]
Github pull request

IMO- "Vertical" is a terrible name to present to the user. Asking for a better name from UX

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8443661 [details] [review]
Github pull request

James - better now? :)

Comment 5

[Théo Chevalier]

(In reply to Kevin Grandon :kgrandon from comment #4)
> Comment on attachment 8443661 [details] [review]
> Github pull request
> 
> James - better now? :)

Or just "Vertical Homescreen"? Because in 2.1 we'll have both horizontal and vertical homescreen (If I understood correctly). Or we'll change the name in 2.1?

Thanks Kevin, I'll test your patch by adding the translations to this file https://hg.mozilla.org/gaia-l10n/fr/file/956f23726cf1/apps/verticalhome/manifest.properties

Comment 6

[Kevin Grandon :kgrandon]

I don't really know what we will have in 2.1, so because of that I think sticking with just "Homescreen" probably makes sense for now while we only have one option. Let's change it in the future if we need to.

Comment 7

[Théo Chevalier]

(In reply to Kevin Grandon :kgrandon from comment #6)
> I don't really know what we will have in 2.1, so because of that I think
> sticking with just "Homescreen" probably makes sense for now while we only
> have one option. Let's change it in the future if we need to.

Ok

About the patch, I think you'll need JS to explicitly get the translations from manifest.properties file on each place where the name is displayed. But I'll try your patch anyway, I may be wrong.

Comment 8

[Théo Chevalier]

Comment on attachment 8443661 [details] [review]
Github pull request

Ok, I added the two strings to the italian file: https://hg.mozilla.org/gaia-l10n/it/file/f712f214e67e/apps/verticalhome/manifest.properties

name= This is a test
description=This is another test

Then I flashed my phone and the App name was localized. However I went back to another locale which doesn't have the strings (French here), and it displays this string instead https://hg.mozilla.org/gaia-l10n/fr/file/956f23726cf1/apps/system/manifest.properties#l1

Also, not sure how to get the strings added to the en-US l10n repository.

Comment 9

[Kevin Grandon :kgrandon]

AFAIK, all we are supposed to do is supply the value in the manifest.webapp and it should work. Not really what else we should do from our side as I'm not too familiar with how the manifests are localized.

Comment 10

[Jacqueline Savory [:jsavory] UX]

As Kevin suggested, "Homescreen" works for me and is much better than "Vertical".

Comment 11

[Théo Chevalier]

Let's hope
"en-US": {
      "name": "Homescreen",
      "description": "Gaia Homescreen"
    }

will do the trick, and the string will be automatically added to https://hg.mozilla.org/gaia-l10n/en-US/file/c9b6166c0d0f/apps/verticalhome/manifest.properties

Comment 12

[Théo Chevalier]

Comment on attachment 8443661 [details] [review]
Github pull request

As stated on #c1, I'm not a reviewer, but stamping this one since I can get the App name localized on my phone.

Thanks Kevin! I'll talk to RelMan to get the bug 2.0+

Comment 13

[Kevin Grandon :kgrandon]

Landed: https://github.com/mozilla-b2g/gaia/commit/49ebd48acdf9938dd00adbfec7955a24975411d7

Comment 14

[John Ford [:jhford] CET/CEST Berlin Time]

[v2.0 dbadf13] Merge pull request #20819 from KevinGrandon/bug_1028351_vertical_manifest_localization

Comment 15

[Kevin Grandon :kgrandon]

Reverting for breaking a gaia ui test:

https://github.com/mozilla-b2g/gaia/commit/64eab1784877cf939f6af40242e75ba204f65c20
https://github.com/mozilla-b2g/gaia/commit/b0ca5d7bc14e2b115ca4cef68e30cce4c36fe667

We will fix the test and get this re-landed. Sorry about that.

Comment 16

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Ok, updated the hardcoded values in the tests, which I didn't expect to be there. Sorry about that, waiting for a green build this time.

Carrying the review as the test changes are minor.

Comment 17

[Kevin Grandon :kgrandon]

Ok, we have some green runs now, so landing again: https://github.com/mozilla-b2g/gaia/pull/20798

Master: https://github.com/mozilla-b2g/gaia/commit/7fc68e666e1e3c4c4d76103e2d8ea6d47a5904f5
2.0: https://github.com/mozilla-b2g/gaia/commit/c0bbfc2e09cb1f392b49c3bfa08af0426aefbbd9