Closed Bug 1028359 Opened 10 years ago Closed 10 years ago

[B2G][Gallery][Edit Photo]Taskbar options at bottom of screen flicker if image is high enough resolution (~8MP)

Categories

(Firefox OS Graveyard :: Gaia::Gallery, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:2.0+, b2g-v1.4 affected, b2g-v2.0 fixed, b2g-v2.1 fixed)

RESOLVED FIXED
2.0 S6 (18july)
blocking-b2g 2.0+
Tracking Status
b2g-v1.4 --- affected
b2g-v2.0 --- fixed
b2g-v2.1 --- fixed

People

(Reporter: rkuhlman, Assigned: pdahiya)

Details

(Whiteboard: [2.0-daily-testing])

Attachments

(3 files)

Attached file EditColorLog.txt
The edit color tool in the photo gallery does not function properly with high resolution pictures. The taskbars at the bottom of the screen flicker constantly. (the color taskbar, and the taskbar that contains brighntess, cropping, color and auto-enhance)

I can reproduce this issue 100% of the time with pictures taken on a Google Nexus 5, which has a standard 8mp camera. Issue also reproduces with pictures taken on iPhone 4S


Repro Steps:
prerequisite: have another device that has an 8mp or higher camera

1) Update a Flame to BuildID: 20140620000202
2) Take a picture on other device
3) Transfer picture to FxOS (MMS, Bluetooth, or USB transfer)
4) On FxOS device, launch gallery
5) Locate and edit the picture from step 3
6) Tap on the 'edit color' button at the bottom of the screen (3 circles intersecting)

Actual:
Icons on the bottom taskbar flicker and disappear frequently

Expected:
All onscreen icons are plainly visible and do not flicker

v2.0 Environmental Variables:
Device: Flame v2.0 MOZ
BuildID: 20140620000202
Gaia: c5dd47e3f9e18872961946735fdbc071a1656ac9
Gecko: 71b1b4b0850c
Version: 32.0a2
Firmware Version: v121-2

Notes:
Video of issue can be found here: https://www.youtube.com/watch?edit=vd&v=pkTZZ4m_Joc

Repro frequency: 100%
See attached: video, logcat
The taskbar flickers when selecting color on a high resolution image in latest 2.1. Issue reproduces on todays 2.1 build.

BuildID: 20140620040204
Gaia: ccd70903544486bea04e85d8a4aacf63f1de2a72
Gecko: bdac18bd6c74
Version: 33.0a1
Firmware Version: v122
QA Whiteboard: [QAnalyst-Triage?]
status-b2g-v1.4: --- → ?
Flags: needinfo?(jmitchell)
Keywords: qawanted
Whiteboard: [2.0-daily-testing]
QA-Wanted to do Branch / Device checks
Flags: needinfo?(jmitchell)
QA Whiteboard: [QAnalyst-Triage?]
QA Contact: ckreinbring
Bug repros on Flame 2.1, Flame 2.0, Flame 1.4 and Buri 2.1

Flame 2.1
Build ID: 20140702040207
Gaia: 85e97290431ce6aa0a965421e84d6070cd899129
Gecko: 7075808c3306
Platform Version: 33.0a1
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

Flame 2.0
Build ID: 20140702000201
Gaia: 3bfe47c58c959c42f5ffe0309b5380ea514ccd69
Gecko: f40e767ea283
Platform Version: 32.0a2
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Flame 1.4
Build ID: 20140630000201
Gaia: aa896d5db1b4929f3bf31a0f4bb7de50530222a8
Gecko: 8cba60bc12ef
Platform Version: 30.0
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

Buri 2.1
Build ID: 20140702060700
Gaia: b0ddb2122771e25cdd880359406a53b10cdc0507
Gecko: e82a9700f94b
Platform Version: 33.0a1
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

Actual result: When attempting to edit a high resolution picture in the Gallery app, the menu bars flicker if the Color option is selected.
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(jmitchell)
Keywords: qawanted
not a regression
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(jmitchell)
Wayne - Could this be a problem for Madai? Trying to figure out if the highest end device we have planned for 2.0 could be affected by this or not.
QA Whiteboard: [QAnalyst-Triage+] → [QAnalyst-Triage+][lead-review+]
Flags: needinfo?(wchang)
Yes, it will be a problem for a couple of upcoming partners and I imagine going forward more devices will be affected.

Video looks pretty bad so it would be good to get this fixed in earlier releases rather than later.
Flags: needinfo?(wchang)
blocking-b2g: --- → 2.0?
Investigated and the underlying issue resulting in flicker is similar to Bug1011460. 

https://github.com/mozilla-b2g/gaia/blob/master/apps/gallery/js/ImageEditor.js#L108

When we are editing high resolution picture ~ 8MP,  edit-effect-options thumbnails  are using lot more image memory causing b2g to swap images in and out (See Bug 993825 for the original issue in gecko).

As a fix inside gallery app, we should decode edit-effect-options thumbnails smaller using  #-moz-samplesize media fragment, looking into the fix

Setting NI flag for the reporter to attach a sample image to the bug. Thanks
Flags: needinfo?(rkuhlman)
Triage : 2.0+ because we will have mid-teir devices in 2.0 and up.
blocking-b2g: 2.0? → 2.0+
Attached image Sample8mpImage.jpg
I was able to reproduce the flickering issue in gallery when attempting to edit the attached image.

This image was taken using the rear camera of a Google Nexus 5 device, and transferred to the Flame device via bluetooth transfer
Flags: needinfo?(rkuhlman)
Assignee: nobody → pdahiya
Attaching WIP patch for fixing flickering seen while editing effects for high resolution images.
Still working on how attached patch handles different image types before submitting it for review.
Comment on attachment 8453684 [details] [review]
Patch having fix for Bug 1028359

Hi David
Plese review attached patch that downsamples high resolution jpeg background images into smaller images.
The patch works for non-jpeg types as the maximum resolution allowed for non-jpeg types is 5M Pixels.Tested PNG with resolution 3334 x 1289 , ~ 4.2 M pixels and the edit-effect options image buttons look good. Please review. Thanks
Attachment #8453684 - Attachment description: WIP Patch having fix for Bug 1028359 → Patch having fix for Bug 1028359
Attachment #8453684 - Flags: review?(dflanagan)
> The patch works for non-jpeg types as the maximum resolution allowed for
> non-jpeg types is 5M Pixels.

Tested on Flame 2.1 with CONFIG_MAX_IMAGE_PIXEL_SIZE as 5M pixels.
Comment on attachment 8453684 [details] [review]
Patch having fix for Bug 1028359

Punam,

Thanks for finding this. I'm embarrassed that we were using the full size image for those buttons! Tif has proposed an overhaul of the image editor UX, and when we do that, we should be sure to use the preview image rather than the original image.

For now, this downsample solution is good enough. Rather than hardcoding 1/4, however, I propose that you calculate the downsample amount more precisely.  See my comment on github, and the code I propose there.

If you make (and test) that change, then r+ for landing this.  If you'd like me to review it again, just reset the r? flag and I can take another look.
Attachment #8453684 - Flags: review?(dflanagan) → review+
Thanks David for review feedback, it works great! Tested the updated patch on Flame and Hamachi latest master build and downsampling using area of the image improves the experience for low resolution images .

Patch landed on master
https://github.com/mozilla-b2g/gaia/commit/ca2e07c5fe918e522a9a37468cd563fec338e405
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: