1028392 - Address review comments from Bug 1027251

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Adam Roach [:abr]]

The various approvals for the patches attached to Bug 1027251 included several that were conditional upon certain changes being addressed:

https://bugzilla.mozilla.org/show_bug.cgi?id=1027251#c14
https://bugzilla.mozilla.org/show_bug.cgi?id=1027251#c17
https://bugzilla.mozilla.org/show_bug.cgi?id=1027251#c19
https://bugzilla.mozilla.org/show_bug.cgi?id=1027251#c25

I'm opening this bug for the purpose of addressing these review comments.

Comment 1

[Benoit Jacob [:bjacob] (mostly away)]

Ouch, it does seem that I forgot to address comment 25. The other comments listed above are addressed already, right?

Comment 2

[Adam Roach [:abr]]

(In reply to Benoit Jacob [:bjacob] from comment #1)
> Ouch, it does seem that I forgot to address comment 25. The other comments
> listed above are addressed already, right?

Sorry -- I didn't audit the other patches. I found that my comments weren't addressed and assumed that we had a disconnect around the nature of reviews, not a simple "I forgot one" error.

Thanks for the rapid response.