1028427 - Build bustage: nsProxyRelease.h(149) : error C2338: Reference-counted classes should not have a public destructor

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Honza Bambas (:mayhemer)]

Win7, MSVC2013, debug build, up-to-date m-c (@776f6d341b3f), no patches, clobbered.

 3:33.50 AppSignatureVerification.cpp
 3:33.50 c:\Mozilla\src\mozilla-central\_obj-browser-debug\dist\include\nsProxyRelease.h(149) : error C2338: Reference-counted classes should not have a p
ublic destructor. Try to make this class's destructor non-public. If that is really not possible, you can whitelist this class by providing a HasDangerous
PublicDestructor specialization for it.
 3:33.50         c:\Mozilla\src\mozilla-central\_obj-browser-debug\dist\include\nsProxyRelease.h(149) : while compiling class template member function 'Mo
zExternalRefCountType nsMainThreadPtrHolder<T>::AddRef(void)'
 3:33.50         with
 3:33.50         [
 3:33.50             T=nsIOpenSignedAppFileCallback
 3:33.50         ]
 3:33.50         c:\mozilla\src\mozilla-central\_obj-browser-debug\dist\include\nsAutoPtr.h(903) : see reference to function template instantiation 'MozEx
ternalRefCountType nsMainThreadPtrHolder<T>::AddRef(void)' being compiled
 3:33.50         with
 3:33.50         [
 3:33.50             T=nsIOpenSignedAppFileCallback
 3:33.50         ]
 3:33.50         c:/Mozilla/src/mozilla-central/security/apps/AppSignatureVerification.cpp(806) : see reference to class template instantiation 'nsMainThr
eadPtrHolder<T>' being compiled
 3:33.50         with
 3:33.50         [
 3:33.50             T=nsIOpenSignedAppFileCallback
 3:33.50         ]
 3:33.51
 3:33.52 In the directory  /c/Mozilla/src/mozilla-central/_obj-browser-debug/security/apps
 3:33.52 The following command failed to execute properly:
 3:33.52 c:/Mozilla/src/mozilla-central/_obj-browser-debug/_virtualenv/Scripts/python.exe -m mozbuild.action.cl cl -FoAppSignatureVerification.obj -c -I..
/../dist/stl_wrappers -DNSS_ENABLE_ECC=True -DDLL_PREFIX="" -DDLL_SUFFIX=".dll" -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DNO_NSPR_10_SUPPORT -Ic:/Mozilla/src
/mozilla-central/security/apps -I. -Ic:/Mozilla/src/mozilla-central/security/apps/../certverifier -Ic:/Mozilla/src/mozilla-central/security/apps/../manage
r/ssl/src -Ic:/Mozilla/src/mozilla-central/security/apps/../pkix/include -I../../dist/include -Ic:/Mozilla/src/mozilla-central/_obj-browser-debug/dist/inc
lude/nspr -Ic:/Mozilla/src/mozilla-central/_obj-browser-debug/dist/include/nss -I/c/Mozilla/src/mozilla-central/_obj-browser-debug/dist/include -I/c/Mozil
la/src/mozilla-central/modules/zlib/src -MD -FI ../../dist/include/mozilla-config.h -DMOZILLA_CLIENT -TP -nologo -D_HAS_EXCEPTIONS=0 -W3 -Gy -FS -Gw -wd42
51 -wd4244 -wd4345 -wd4351 -wd4482 -wd4800 -wd4819 -we4553 -GR- -DDEBUG -DTRACING -Z7 -Oy- -WX c:/Mozilla/src/mozilla-central/security/apps/AppSignatureVe
rification.cpp
 3:33.52 c:/Mozilla/src/mozilla-central/config/rules.mk:1005: recipe for target 'AppSignatureVerification.obj' failed
 3:33.52 mozmake.EXE[5]: *** [AppSignatureVerification.obj] Error 1
 3:33.52 c:/Mozilla/src/mozilla-central/config/recurse.mk:95: recipe for target 'security/apps/compile' failed
 3:33.52 mozmake.EXE[4]: *** [security/apps/compile] Error 2
 3:33.52 mozmake.EXE[4]: *** Waiting for unfinished jobs....

Comment 1

[Honza Bambas (:mayhemer)]

Or rather from bug 1027251?

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

da007249e737 should have fixed exactly that - thanks to khuey. The cset specified in comment 0, 776f6d341b3f, did not have that merged in. So I'm feeling confident enough to mark this as fixed, though do feel free to reopen if needed.

Comment 3

[Bob Clary [:bc] (inactive)]

Attachment: error

I still see this on win7 x86_64 with vs 2012 and mozilla central 366b5c0c02d3

Comment 4

[Bob Clary [:bc] (inactive)]

Note I don't see this with win 7 x86 with vs 2010.

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

The changeset that fixed this is still only on inbound.  Somebody needs to merge.

Comment 6

[Honza Bambas (:mayhemer)]

Confirming m-c builds for me with da007249e737 (manually) merged in.  Thanks!

Comment 7

[Bob Clary [:bc] (inactive)]

(In reply to Kyle Huey [:khuey] ([e-mail]) from comment #5)
> The changeset that fixed this is still only on inbound.  Somebody needs to
> merge.

That's https://bugzilla.mozilla.org/show_bug.cgi?id=1027251#c59 ?

Normally don't we leave bugs open until they have been merged into m-c?

Comment 8

[Bob Clary [:bc] (inactive)]

I was able to successfully build mc today. -> fixed again. thanks.