1028443 - [Vertical Homescreen] Pressing the home button returns to top after showing card views

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Johan Lorenzo [:jlorenzo]]

STR
1. Go to the bottom of the homescreen
2. Long press the home button to show the card views
3. Tap the home button again

Expected results
Tapping the home button should return to the homescreen

Actual
Tapping the home button returns to the homescreen and triggers the animation which makes the homescreen go to the top

Comment 1

[Johan Lorenzo [:jlorenzo]]

From a UX perspective, is the current behavior the correct one?

Comment 2

[Jacqueline Savory [:jsavory] UX]

No, in this case the expected results is the correct behaviour. 
When the user taps home from the cards view it should only return them to the homescreen. The homescreen should not change its position.

Comment 3

[Kevin Grandon :kgrandon]

Seems like when cards view is open we should not dispatch the home event to the homescreen.

Comment 4

[Cristian Rodriguez (:crdlc)]

Attachment: 1028443.patch

Hi Alive, I only want to help here but I don't know if this is the correct patch to fix it. Could you take a look at this patch? Thanks a lot for your support

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8445093 [details] [diff] [review]
1028443.patch

Review of attachment 8445093 [details] [diff] [review]:
-----------------------------------------------------------------

If we don't ensure the homescreen here and it's killed while task manager is shown,
then the patch will never get the homescreen back while the task manager appears and the user press home button.

The proper solution looks to me is
(1) Listen home event in task manager
(2) Stop immediate propagation and hide self
*(3) Make sure app window manager registers the home event after the task manager to make (2) happen.*

Comment 6

[Cristian Rodriguez (:crdlc)]

I thought about it but I didn't know how to fix it because the app window manager is initialized by itself when it is appended to the DOM but the task manager is created after the page is loaded in the bootstrap. It does not seem a straightforward implementation for me because of my lack of knowledge regarding to system app.

Comment 7

[Cristian Rodriguez (:crdlc)]

It is working fine now once that the bug 1020917 was landed