Open Bug 1028456 Opened 7 years ago Updated 5 years ago

More leaks with _PR_Getfd

Categories

(Core :: XPCOM, defect)

defect
Not set
normal

Tracking

()

People

(Reporter: mccr8, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [MemShrink:P3])

Attachments

(1 file)

No description provided.
Two more fd-related leaks showed up on the merge from m-c.  The bc1 wasn't happening 100% of the time.  I landed a new fairly broad suppression of _PR_Getfd for them, as there are a few variants of this that have shown up, and I have no idea what is going on.
We're actually suppressing the _PR_Getfd leaks pretty broadly now, FWIW, because they kept coming up.  Though pretty small each time.
Whiteboard: [MemShrink]
Whiteboard: [MemShrink] → [MemShrink:P3]
Just out of curiosity, are LSAN runs --enable-debug or --disable-debug?
Flags: needinfo?(continuation)
Disable.  This does cause problems in some areas of the code that don't bother running cleanup code in non-debug builds.
Flags: needinfo?(continuation)
(In reply to Andrew McCreight [:mccr8] from comment #4)
> Disable.  This does cause problems in some areas of the code that don't
> bother running cleanup code in non-debug builds.

Hm.  NSPR has some code to recycle its internal file descriptors and comments claim that it is "disabled in opt builds", but reading the code, it looks like that comment is inaccurate.  The caching logic looks...confusing.

The cache ought to be cleared on shutdown via PR_Cleanup, but I don't think we ever call that...?
Depends on: 573192
Duplicate of this bug: 1021854
Duplicate of this bug: 1021302
See Also: → 1250995
This is still pretty widespread across the mochitest suites.
You need to log in before you can comment on or make changes to this bug.