Closed Bug 1028521 Opened 6 years ago Closed 6 years ago

"ASSERTION: writing-mode mismatch" with MathML

Categories

(Core :: Layout, defect)

x86_64
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: jruderman, Assigned: smontagu)

References

(Blocks 1 open bug)

Details

(Keywords: assertion, testcase)

Attachments

(5 files)

Attached file testcase
###!!! ASSERTION: writing-mode mismatch: 'aWritingMode == mWritingMode', file /Users/jruderman/trees/mozilla-central/layout/generic/nsHTMLReflowMetrics.h, line 239
Attached file stack
Jesse's testcase as a crashtest. Fails (asserts, twice) on current trunk; passes with the patch above.
Attachment #8443949 - Flags: review?(smontagu)
Attachment #8443949 - Flags: review?(smontagu) → review+
Comment on attachment 8443948 [details] [diff] [review]
use the right writing mode for child's reflow metrics.

Review of attachment 8443948 [details] [diff] [review]:
-----------------------------------------------------------------

No, I think this is the wrong fix: AIUI in Reflow methods the nsHTMLReflowMetrics should be in the writing mode of the container frame, not the reflowee.
Attachment #8443948 - Flags: review?(smontagu) → review-
I think this is the way to go.
Attachment #8444351 - Flags: review?(jfkthame)
Comment on attachment 8444351 [details] [diff] [review]
Use the metrics' writing mode in ReflowChild

Review of attachment 8444351 [details] [diff] [review]:
-----------------------------------------------------------------

OK, that makes sense.
Attachment #8444351 - Flags: review?(jfkthame) → review+
https://hg.mozilla.org/mozilla-central/rev/3f7edaaebc90
https://hg.mozilla.org/mozilla-central/rev/7320004519ea
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
Assignee: nobody → smontagu
You need to log in before you can comment on or make changes to this bug.