Closed
Bug 1028536
Opened 10 years ago
Closed 9 years ago
Dead code in BasicImageLayer
Categories
(Core :: Graphics: Layers, defect)
Tracking
()
RESOLVED
FIXED
mozilla38
People
(Reporter: cgg, Assigned: cgg)
Details
Attachments
(1 file)
|
2.08 KB,
patch
|
nical
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (X11; Linux i686; rv:33.0) Gecko/20100101 Firefox/33.0 (Beta/Release) Build ID: 20140621124709 Steps to reproduce: Go to mozilla-central worktree. Look for occurences of GetAndPaintCurrentImage (method of BasicImageLayer) Actual results: There are two occurences, the definition and the implementation. The method is not used anywhere. Expected results: Uses of the method.
|
Assignee | |
Updated•10 years ago
|
OS: Linux → All
Hardware: x86 → All
|
||
Updated•10 years ago
|
Assignee: nobody → clement.geiger
|
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8443912 -
Flags: review?(nical.bugzilla)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8443912 [details] [diff] [review] Remove BasicImageLayer::GetAndPaintCurrentImage. Review of attachment 8443912 [details] [diff] [review]: ----------------------------------------------------------------- r+ if green try push
Attachment #8443912 -
Flags: review?(nical.bugzilla) → review+
|
|
||
Comment 3•10 years ago
|
||
try: https://tbpl.mozilla.org/?tree=Try&rev=fd0c143c6e99
|
||
Updated•10 years ago
|
Status: UNCONFIRMED → NEW
Component: Untriaged → Graphics: Layers
Ever confirmed: true
Product: Firefox → Core
|
|
||
Comment 5•9 years ago
|
||
Aye! https://hg.mozilla.org/integration/mozilla-inbound/rev/52156df5e298
Flags: needinfo?(nical.bugzilla)
|
||
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/52156df5e298
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in
before you can comment on or make changes to this bug.
Description
•