Closed
Bug 1028563
Opened 10 years ago
Closed 10 years ago
Flatten away public/src subdirectories under accessible/
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: poiru, Assigned: poiru)
References
Details
Attachments
(2 files)
74.68 KB,
patch
|
surkov
:
review+
|
Details | Diff | Splinter Review |
8.49 KB,
patch
|
surkov
:
review+
|
Details | Diff | Splinter Review |
Flatten away public/src subdirectories under accissible (similar to bug 946065 for content/).
Comment 2•10 years ago
|
||
I'm ok with it in general. How folder hierarchy would look like?
Flags: needinfo?(surkov.alexander)
Assignee | ||
Comment 3•10 years ago
|
||
(In reply to alexander :surkov from comment #2) > I'm ok with it in general. How folder hierarchy would look like? First, accessible/src/base/* would be moved to accessible/src/. Then, accessible/src/* would be moved to accessible/. With accessible/public/, we have several options: 1) Move accessible/public/* into accessible/ 2) Rename accessible/public/ to accessible/interfaces/ (like dom/interfaces) 3) Leave it alone. Any thoughts?
Comment 4•10 years ago
|
||
2nd option looks good, especially if it pretends to become a common pattern
Comment 5•10 years ago
|
||
(In reply to Birunthan Mohanathas [:poiru] from comment #3) > First, accessible/src/base/* would be moved to accessible/src/. Then, > accessible/src/* would be moved to accessible/. do you want to get rid base directory? why?
Assignee | ||
Comment 6•10 years ago
|
||
(In reply to alexander :surkov from comment #5) > (In reply to Birunthan Mohanathas [:poiru] from comment #3) > > First, accessible/src/base/* would be moved to accessible/src/. Then, > > accessible/src/* would be moved to accessible/. > > do you want to get rid base directory? why? I somehow remembered that bug 946065 did that as well, but apparently I was mistaken.
Assignee: nobody → birunthan
Status: NEW → ASSIGNED
Attachment #8444131 -
Flags: review?(surkov.alexander)
Assignee | ||
Comment 7•10 years ago
|
||
Attachment #8444132 -
Flags: review?(surkov.alexander)
Comment 8•10 years ago
|
||
Comment on attachment 8444131 [details] [diff] [review] Flatten away src subdirectory under accessible/ Review of attachment 8444131 [details] [diff] [review]: ----------------------------------------------------------------- rs=me
Attachment #8444131 -
Flags: review?(surkov.alexander) → review+
Comment 9•10 years ago
|
||
Comment on attachment 8444132 [details] [diff] [review] Rename accessible/public/ to accessible/interfaces/ Review of attachment 8444132 [details] [diff] [review]: ----------------------------------------------------------------- rs=me
Attachment #8444132 -
Flags: review?(surkov.alexander) → review+
Assignee | ||
Comment 10•10 years ago
|
||
Try push: https://tbpl.mozilla.org/?tree=Try&rev=44b65ea7cb6e https://hg.mozilla.org/integration/mozilla-inbound/rev/85b4fe3a7fa9 https://hg.mozilla.org/integration/mozilla-inbound/rev/e3858c50afba
Comment 11•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/85b4fe3a7fa9 https://hg.mozilla.org/mozilla-central/rev/e3858c50afba
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in
before you can comment on or make changes to this bug.
Description
•