1028563 - Flatten away public/src subdirectories under accessible/

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[poiru]

Flatten away public/src subdirectories under accissible (similar to bug 946065 for content/).

Comment 1

[poiru]

Would you be OK with this?

Comment 2

[alexander :surkov (:asurkov)]

I'm ok with it in general. How folder hierarchy would look like?

Comment 3

[poiru]

(In reply to alexander :surkov from comment #2)
> I'm ok with it in general. How folder hierarchy would look like?

First, accessible/src/base/* would be moved to accessible/src/. Then, accessible/src/* would be moved to accessible/.

With accessible/public/, we have several options:
1) Move accessible/public/* into accessible/
2) Rename accessible/public/ to accessible/interfaces/ (like dom/interfaces)
3) Leave it alone.

Any thoughts?

Comment 4

[alexander :surkov (:asurkov)]

2nd option looks good, especially if it pretends to become a common pattern

Comment 5

[alexander :surkov (:asurkov)]

(In reply to Birunthan Mohanathas [:poiru] from comment #3)
> First, accessible/src/base/* would be moved to accessible/src/. Then,
> accessible/src/* would be moved to accessible/.

do you want to get rid base directory? why?

Comment 6

[poiru]

Attachment: Flatten away src subdirectory under accessible/

(In reply to alexander :surkov from comment #5)
> (In reply to Birunthan Mohanathas [:poiru] from comment #3)
> > First, accessible/src/base/* would be moved to accessible/src/. Then,
> > accessible/src/* would be moved to accessible/.
> 
> do you want to get rid base directory? why?

I somehow remembered that bug 946065 did that as well, but apparently I was mistaken.

Comment 7

[poiru]

Attachment: Rename accessible/public/ to accessible/interfaces/

Comment 8

[alexander :surkov (:asurkov)]

Comment on attachment 8444131 [details] [diff] [review]
Flatten away src subdirectory under accessible/

Review of attachment 8444131 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me

Comment 9

[alexander :surkov (:asurkov)]

Comment on attachment 8444132 [details] [diff] [review]
Rename accessible/public/ to accessible/interfaces/

Review of attachment 8444132 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me

Comment 10

[poiru]

Try push: https://tbpl.mozilla.org/?tree=Try&rev=44b65ea7cb6e

https://hg.mozilla.org/integration/mozilla-inbound/rev/85b4fe3a7fa9
https://hg.mozilla.org/integration/mozilla-inbound/rev/e3858c50afba

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/85b4fe3a7fa9
https://hg.mozilla.org/mozilla-central/rev/e3858c50afba