Flatten away public/src subdirectories under accessible/

RESOLVED FIXED in mozilla33

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: poiru, Assigned: poiru)

Tracking

Trunk
mozilla33
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

4 years ago
Flatten away public/src subdirectories under accissible (similar to bug 946065 for content/).
(Assignee)

Comment 1

4 years ago
Would you be OK with this?
Flags: needinfo?(surkov.alexander)
I'm ok with it in general. How folder hierarchy would look like?
Flags: needinfo?(surkov.alexander)
(Assignee)

Comment 3

4 years ago
(In reply to alexander :surkov from comment #2)
> I'm ok with it in general. How folder hierarchy would look like?

First, accessible/src/base/* would be moved to accessible/src/. Then, accessible/src/* would be moved to accessible/.

With accessible/public/, we have several options:
1) Move accessible/public/* into accessible/
2) Rename accessible/public/ to accessible/interfaces/ (like dom/interfaces)
3) Leave it alone.

Any thoughts?
2nd option looks good, especially if it pretends to become a common pattern
(In reply to Birunthan Mohanathas [:poiru] from comment #3)
> First, accessible/src/base/* would be moved to accessible/src/. Then,
> accessible/src/* would be moved to accessible/.

do you want to get rid base directory? why?
(Assignee)

Comment 6

4 years ago
Created attachment 8444131 [details] [diff] [review]
Flatten away src subdirectory under accessible/

(In reply to alexander :surkov from comment #5)
> (In reply to Birunthan Mohanathas [:poiru] from comment #3)
> > First, accessible/src/base/* would be moved to accessible/src/. Then,
> > accessible/src/* would be moved to accessible/.
> 
> do you want to get rid base directory? why?

I somehow remembered that bug 946065 did that as well, but apparently I was mistaken.
Assignee: nobody → birunthan
Status: NEW → ASSIGNED
Attachment #8444131 - Flags: review?(surkov.alexander)
(Assignee)

Comment 7

4 years ago
Created attachment 8444132 [details] [diff] [review]
Rename accessible/public/ to accessible/interfaces/
Attachment #8444132 - Flags: review?(surkov.alexander)
Comment on attachment 8444131 [details] [diff] [review]
Flatten away src subdirectory under accessible/

Review of attachment 8444131 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me
Attachment #8444131 - Flags: review?(surkov.alexander) → review+
Comment on attachment 8444132 [details] [diff] [review]
Rename accessible/public/ to accessible/interfaces/

Review of attachment 8444132 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me
Attachment #8444132 - Flags: review?(surkov.alexander) → review+
https://hg.mozilla.org/mozilla-central/rev/85b4fe3a7fa9
https://hg.mozilla.org/mozilla-central/rev/e3858c50afba
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
Depends on: 1030598
You need to log in before you can comment on or make changes to this bug.