1028633 - Use gcc inline assembly in xptcstubs.cpp for clang-cl

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[(no longer active)]

clang-cl's support for naked functions is also broken similar to gcc.  In particular, it clobbers eax.  It's best to just use the gcc inline assembly implementation here which works fine in both clang-cl and mingw.  Note that I had to add a bit of clang-cl specific code because of the name mangling differences.

Comment 1

[(no longer active)]

Attachment: Use gcc inline assembly in xptcstubs.cpp for clang-cl

Comment 2

[(no longer active)]

Comment on attachment 8444028 [details] [diff] [review]
Use gcc inline assembly in xptcstubs.cpp for clang-cl

Err, this is the wrong patch...

Comment 3

[(no longer active)]

Attachment: Use gcc inline assembly in xptcstubs.cpp for clang-cl

Comment 4

[Benjamin Smedberg]

Does clang-cl use the GCC ABI or the MSVC ABI?

Comment 5

[Jeff Muizelaar [:jrmuizel]]

(In reply to Benjamin Smedberg  [:bsmedberg] from comment #4)
> Does clang-cl use the GCC ABI or the MSVC ABI?

MSVC ABI

Comment 6

[(no longer active)]

Note that this patch just makes us use the gcc inline assembly to implement the stubs, it doesn't change anything ABI sensitive.

https://hg.mozilla.org/integration/mozilla-inbound/rev/6279aec8541c

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/6279aec8541c