1028678 - Build broken after bug 1019955 landed

Status: RESOLVED WONTFIX

(Core :: JavaScript Engine, defect)

Comment 1

[Robert Longson [:longsonr]]

Backing out bug 1019955 locally fixes my build.

make.py[0]: Entering directory 'c:\moz2\mozilla-inbound2\obj-i686-pc-mingw32\js\src'
make.py[1]: Entering directory 'c:\moz2\mozilla-inbound2\obj-i686-pc-mingw32\js\src'
c:\moz2\mozilla-inbound2\obj-i686-pc-mingw32\js\src\Makefile:410:0$ c:/moz2/mozilla-inbound2/obj-i686-pc-mingw32/_virtualenv/Scripts/python.exe c:/moz2/mozilla-inbound2/js/src/builtin/embedjs.py -DFFI_BUILDING -D_CRT_RAND_S -DENABLE_PARALLEL_JS -DENABLE_BINARYDATA -DENABLE_SHARED_ARRAY_BUFFER -DJSGC_FJGENERATIONAL -DEXPORT_JS_API -DJS_HAS_CTYPES -DDLL_PREFIX='""' -DDLL_SUFFIX='".dll"' -DUSE_SYSTEM_MALLOC=1 -DENABLE_ASSEMBLER=1 -DNO_NSPR_10_SUPPORT -DUSE_ZLIB -DMOZILLA_VERSION='"33.0a1"' -DMOZILLA_VERSION_U='33.0a1' -DMOZILLA_UAVERSION='"33.0"' -DMOZJS_MAJOR_VERSION='33' -DMOZJS_MINOR_VERSION='0' -D_CRT_SECURE_NO_WARNINGS='1' -D_CRT_NONSTDC_NO_WARNINGS='1' -DHAVE_WINSDKVER_H='1' -DWINVER='0x502' -D_WIN32_WINNT='0x502' -D_WIN32_IE='0x0603' -DMOZ_WINSDK_TARGETVER='0x06010000' -DMOZ_NTDDI_WIN7='0x06010000' -DHAVE_LOCALECONV='1' -DHAVE_HYPOT='1' -DX_DISPLAY_MISSING='1' -DHAVE_SNPRINTF='1' -D_WINDOWS='1' -DWIN32='1' -DXP_WIN='1' -DXP_WIN32='1' -DHW_THREADS='1' -DSTDC_HEADERS='1' -DWIN32_LEAN_AND_MEAN='1' -DNO_X11='1' -D_X86_='1' -DD_INO='d_ino' -DJS_CPU_X86='1' -DJS_NUNBOX32='1' -DJS_ION='1' -DMOZ_DEBUG_SYMBOLS='1' -DNS_ATTR_MALLOC='' -DNS_WARN_UNUSED_RESULT='' -DMALLOC_H='<malloc.h>' -DHAVE_FORCEINLINE='1' -DHAVE_LOCALECONV='1' -DMOZ_UPDATE_CHANNEL='default' -DNIGHTLY_BUILD='1' -DJS_THREADSAFE='1' -DZLIB_IN_MOZGLUE='1' -DMOZ_MEMORY='1' -DMOZ_MEMORY_DEBUG='1' -DMOZ_MEMORY_WINDOWS='1' -DJSGC_INCREMENTAL='1' -DJSGC_GENERATIONAL='1' -DJSGC_USE_EXACT_ROOTING='1' -DJS_CODEGEN_X86='1' -DJS_DEBUG='1' -DJS_GC_ZEAL='1' -DJS_DEFAULT_JITREPORT_GRANULARITY='3' -DCPP_THROW_NEW='throw()' -DJS_HAS_CTYPES='1' -DMOZ_DLL_SUFFIX='".dll"' -DMOZ_REFLOW_PERF='1' -DMOZ_REFLOW_PERF_DSP='1' -DEXPOSE_INTL_API='1' -DENABLE_INTL_API='1' -DU_USING_ICU_NAMESPACE='0' -DDEBUG -DTRACING \
  -c '%mozbuild.action.cl main  cl' -p '-P -Fi' -m c:/moz2/mozilla-inbound2/js/src/js.msg \
  -o selfhosted.out.h c:/moz2/mozilla-inbound2/js/src/builtin/Utilities.js c:/moz2/mozilla-inbound2/js/src/builtin/ParallelUtilities.js c:/moz2/mozilla-inbound2/js/src/builtin/Array.js c:/moz2/mozilla-inbound2/js/src/builtin/Date.js c:/moz2/mozilla-inbound2/js/src/builtin/Intl.js c:/moz2/mozilla-inbound2/js/src/builtin/IntlData.js c:/moz2/mozilla-inbound2/js/src/builtin/Iterator.js c:/moz2/mozilla-inbound2/js/src/builtin/Map.js c:/moz2/mozilla-inbound2/js/src/builtin/Number.js c:/moz2/mozilla-inbound2/js/src/builtin/String.js c:/moz2/mozilla-inbound2/js/src/builtin/Set.js c:/moz2/mozilla-inbound2/js/src/builtin/TypedObject.js 
Traceback (most recent call last):
  File "c:/moz2/mozilla-inbound2/js/src/builtin/embedjs.py", line 169, in <module>
    main()
  File "c:/moz2/mozilla-inbound2/js/src/builtin/embedjs.py", line 165, in main
    msgs = preprocess(cxx, options.p, MSGS_TEMPLATE % { 'msgs': options.m })
  File "c:/moz2/mozilla-inbound2/js/src/builtin/embedjs.py", line 122, in preprocess
    cxx[0] = which.which(cxx[0])
  File "c:\moz2\mozilla-inbound2\python\which\which.py", line 248, in which
    raise WhichError("Could not find '%s' on the path." % command)
which.WhichError: Could not find '%mozbuild.action.cl' on the path.
c:\moz2\mozilla-inbound2\obj-i686-pc-mingw32\js\src\Makefile:410:0: command 'c:/moz2/mozilla-inbound2/obj-i686-pc-mingw32/_virtualenv/Scripts/python.exe c:/moz2/mozilla-inbound2/js/src/builtin/embedjs.py -DFFI_BUILDING -D_CRT_RAND_S -DENABLE_PARALLEL_JS -DENABLE_BINARYDATA -DENABLE_SHARED_ARRAY_BUFFER -DJSGC_FJGENERATIONAL -DEXPORT_JS_API -DJS_HAS_CTYPES -DDLL_PREFIX='""' -DDLL_SUFFIX='".dll"' -DUSE_SYSTEM_MALLOC=1 -DENABLE_ASSEMBLER=1 -DNO_NSPR_10_SUPPORT -DUSE_ZLIB -DMOZILLA_VERSION='"33.0a1"' -DMOZILLA_VERSION_U='33.0a1' -DMOZILLA_UAVERSION='"33.0"' -DMOZJS_MAJOR_VERSION='33' -DMOZJS_MINOR_VERSION='0' -D_CRT_SECURE_NO_WARNINGS='1' -D_CRT_NONSTDC_NO_WARNINGS='1' -DHAVE_WINSDKVER_H='1' -DWINVER='0x502' -D_WIN32_WINNT='0x502' -D_WIN32_IE='0x0603' -DMOZ_WINSDK_TARGETVER='0x06010000' -DMOZ_NTDDI_WIN7='0x06010000' -DHAVE_LOCALECONV='1' -DHAVE_HYPOT='1' -DX_DISPLAY_MISSING='1' -DHAVE_SNPRINTF='1' -D_WINDOWS='1' -DWIN32='1' -DXP_WIN='1' -DXP_WIN32='1' -DHW_THREADS='1' -DSTDC_HEADERS='1' -DWIN32_LEAN_AND_MEAN='1' -DNO_X11='1' -D_X86_='1' -DD_INO='d_ino' -DJS_CPU_X86='1' -DJS_NUNBOX32='1' -DJS_ION='1' -DMOZ_DEBUG_SYMBOLS='1' -DNS_ATTR_MALLOC='' -DNS_WARN_UNUSED_RESULT='' -DMALLOC_H='<malloc.h>' -DHAVE_FORCEINLINE='1' -DHAVE_LOCALECONV='1' -DMOZ_UPDATE_CHANNEL='default' -DNIGHTLY_BUILD='1' -DJS_THREADSAFE='1' -DZLIB_IN_MOZGLUE='1' -DMOZ_MEMORY='1' -DMOZ_MEMORY_DEBUG='1' -DMOZ_MEMORY_WINDOWS='1' -DJSGC_INCREMENTAL='1' -DJSGC_GENERATIONAL='1' -DJSGC_USE_EXACT_ROOTING='1' -DJS_CODEGEN_X86='1' -DJS_DEBUG='1' -DJS_GC_ZEAL='1' -DJS_DEFAULT_JITREPORT_GRANULARITY='3' -DCPP_THROW_NEW='throw()' -DJS_HAS_CTYPES='1' -DMOZ_DLL_SUFFIX='".dll"' -DMOZ_REFLOW_PERF='1' -DMOZ_REFLOW_PERF_DSP='1' -DEXPOSE_INTL_API='1' -DENABLE_INTL_API='1' -DU_USING_ICU_NAMESPACE='0' -DDEBUG -DTRACING \
  -c '%mozbuild.action.cl main  cl' -p '-P -Fi' -m c:/moz2/mozilla-inbound2/js/src/js.msg \
  -o selfhosted.out.h c:/moz2/mozilla-inbound2/js/src/builtin/Utilities.js c:/moz2/mozilla-inbound2/js/src/builtin/ParallelUtilities.js c:/moz2/mozilla-inbound2/js/src/builtin/Array.js c:/moz2/mozilla-inbound2/js/src/builtin/Date.js c:/moz2/mozilla-inbound2/js/src/builtin/Intl.js c:/moz2/mozilla-inbound2/js/src/builtin/IntlData.js c:/moz2/mozilla-inbound2/js/src/builtin/Iterator.js c:/moz2/mozilla-inbound2/js/src/builtin/Map.js c:/moz2/mozilla-inbound2/js/src/builtin/Number.js c:/moz2/mozilla-inbound2/js/src/builtin/String.js c:/moz2/mozilla-inbound2/js/src/builtin/Set.js c:/moz2/mozilla-inbound2/js/src/builtin/TypedObject.js ' failed, return code 1
c:\moz2\mozilla-inbound2\config\rules.mk:596:0: command 'c:/mozilla-build/python/python.exe c:/moz2/mozilla/build/pymake/pymake/../make.py export' failed, return code 2

Comment 2

[Robert Longson [:longsonr]]

Attachment: .mozconfig

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Do we still support pymake?

Comment 4

[Till Schneidereit [:till]]

(In reply to :Ms2ger from comment #3)
> Do we still support pymake?

I think we don't really.

@Robert, regarldless of the answer to that, you should absolutely use mozmake. Builds are much slower with pymake, and mozmake is the officially supported make nowadays. See https://wiki.mozilla.org/MozillaBuild for details in case you didn't already see that.

Comment 5

[Gregory Szorc [:gps]]

pymake is on its death bed. See bug 1027890. We shouldn't spend time fixing this.