Closed Bug 1028691 Opened 5 years ago Closed 5 years ago

[Collection app] Background images sometimes in poor quality

Categories

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

x86
macOS
defect
Not set

Tracking

(blocking-b2g:2.0+, b2g-v2.0 verified, b2g-v2.1 verified)

VERIFIED FIXED
2.0 S5 (4july)
blocking-b2g 2.0+
Tracking Status
b2g-v2.0 --- verified
b2g-v2.1 --- verified

People

(Reporter: ranbena, Assigned: ranbena)

References

Details

(Whiteboard: [systemsfe])

Attachments

(5 files)

Often newly added Smart Collections have a poor quality background image. When reopening the SC, it updates to a good quality image.
Assignee: nobody → ran
Status: NEW → ASSIGNED
Need a screenshot of the poor quality wallpaper.
Blocks: 1015336
No longer blocks: vertical-homescreen
QA Whiteboard: [VH-FL-blocking-][VH-FC-blocking?]
Keywords: qawanted
Whiteboard: [systemsfe]
Attached image Screenshot.png
Right sorry. Having trouble with getting screenshots on the device for some reason..
(In reply to Ran Ben Aharon (Everything.me) from comment #2)
> Created attachment 8444108 [details]
> Screenshot.png
> 
> Right sorry. Having trouble with getting screenshots on the device for some
> reason..

Ok - we'll probably want to get a screenshot of the good quality image too as a point of comparison.
Attached file Pull Request
Since the collection.background can be updated by two processes - a) Collection create b) Collection view, the former requests a 170x170 image which is then displayed as the Collection content bg. Then gets overwritten with the full size bg.

The fix simply keeps a record if the current bg image is full sized or not and displays only if it is.
Attachment #8444430 - Flags: review?(kgrandon)
Kevin, I'd like to add a unit test with this patch though I think it'll require stubbing the api call. Not sure how to do that.
Comment on attachment 8444430 [details] [review]
Pull Request

James - mind if I pass this off to you? Totally swamped, thanks!
Attachment #8444430 - Flags: review?(kgrandon) → review?(jlal)
Comment on attachment 8444430 [details] [review]
Pull Request

The code itself looks okay and seems to work but I think an integration test like https://github.com/mozilla-b2g/gaia/blob/master/apps/verticalhome/test/marionette/collection_test.js is a better bet then a unit test and should be fairly easy to implement (though I would start splitting up those tests)
Attachment #8444430 - Flags: review?(jlal) → review+
The difference is slightly notable. This looks like a blocker to me. Do you confirm Jason?
Keywords: qawanted
Patryk, would you consider this a blocker?
Flags: needinfo?(padamczyk)
(In reply to Johan Lorenzo [:jlorenzo] from comment #9)
> The difference is slightly notable. This looks like a blocker to me. Do you
> confirm Jason?

I'll wait for Patryk to comment, but given the VD refresh priority needed for 2.0 I'm leaning towards yes.
Attached image comparison.jpg
Attaching a screenshot comparison. It's very noticeable imo.
blocking-b2g: --- → 2.0?
QA Whiteboard: [VH-FL-blocking-][VH-FC-blocking?] → [VH-FL-blocking-][VH-FC-blocking+]
poor ux hence blocking
blocking-b2g: 2.0? → 2.0+
Comment on attachment 8444430 [details] [review]
Pull Request

Updated the PR. No change to code, only added tests.

James, I went for unit tests eventually because it seems more suitable to me in this specific case. Lmk if you have any questions about the tests implementation.
Attachment #8444430 - Attachment description: WIP → Pull Request
Attachment #8444430 - Flags: review+ → review?(jlal)
Comment on attachment 8444430 [details] [review]
Pull Request

LGTM - can you rebase/land this patch?
Attachment #8444430 - Flags: review?(jlal) → review+
Landed on master: https://github.com/mozilla-b2g/gaia/commit/0486f10834bb0a582b0551f31981759f114d9e72
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Kevin, should I uplift to v2.0?
Flags: needinfo?(kgrandon)
Please do, it needs rebasing anyway.
Flags: needinfo?(kgrandon)
Target Milestone: --- → 2.0 S5 (4july)
Flags: needinfo?(padamczyk)
Attached video VIDEO0098_Compress.MP4
This issue has been successfully verified on Flame 2.0:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3
Build-ID        20141201000201
Version         32.0
Device-Name     flame
FW-Release      4.4.2


This issue has been successfully verified on Flame 2.1:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141201001201
Version         34.0
Device-Name     flame
FW-Release      4.4.2
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.