1028702 - Last divider in homescreen displayed after edit mode was activated

Status: RESOLVED DUPLICATE of bug 1028841

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[camel.aissani]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:30.0) Gecko/20100101 Firefox/30.0 (Beta/Release)
Build ID: 20140608211622

Steps to reproduce:

1. Long touch on a app to pass in edit mode
2. Tap the done in the edit bar



Actual results:

The last divider is displayed


Expected results:

The last divider should not be displayed in homescreen

Comment 1

[camel.aissani]

Attachment: 1028702.patch

Used the options.skipItems to avoid to add placeholders on the grid view

Comment 3

[Kevin Grandon :kgrandon]

Comment on attachment 8444114 [details] [diff] [review]
1028702.patch

Review of attachment 8444114 [details] [diff] [review]:
-----------------------------------------------------------------

Unfortunately after this patch i am having a hard time dragging items past the last divider which is supposed to create a new group. I feel like we should probably do some before/after processing in cleanItems to remove this. I can help look into it further this week.

Comment 4

[camel.aissani]

Kevin - My patch does not remove the last group and the placeholders when we are in edit mode.
(It is why I make a test on options.skipItems. This option is setted to true only when we exit the edit mode).

Could you confirm me that you can only move apps in the grid in edit mode?

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to camel.aissani from comment #4)
> Kevin - My patch does not remove the last group and the placeholders when we
> are in edit mode.
> (It is why I make a test on options.skipItems. This option is setted to true
> only when we exit the edit mode).
> 
> Could you confirm me that you can only move apps in the grid in edit mode?

You can only move apps in Edit Mode AFAICT.

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Kevin Grandon :kgrandon from comment #3)
> Comment on attachment 8444114 [details] [diff] [review]
> 1028702.patch
> 
> Review of attachment 8444114 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Unfortunately after this patch i am having a hard time dragging items past
> the last divider which is supposed to create a new group. I feel like we
> should probably do some before/after processing in cleanItems to remove
> this. I can help look into it further this week.

Just tried the patch - and I don't see any diff with/without the patch when it comes to dragging.

Comment 7

[Jason Smith [:jsmith]]

General solution to this problem is being fixed in bug 1028841.

Comment 8

[Kevin Grandon :kgrandon]

It looks like there's been some comments in bug 1028841... We probably should've duped the other way as this was filed first.

In any case, we have a few different patches now it appears =/ I will comment there, but I think I will leave the final implementation up to :Cwiiis.