Closed Bug 1028711 Opened 10 years ago Closed 6 years ago

Touch events not supported in the settings app

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

defect
Not set
normal

Tracking

(tracking-b2g:backlog)

RESOLVED WONTFIX
tracking-b2g backlog

People

(Reporter: lalabelle03, Unassigned, Mentored)

Details

Attachments

(3 files)

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:29.0) Gecko/20100101 Firefox/29.0 (Beta/Release)
Build ID: 20140428194349

Steps to reproduce:

Open the settings configuration page : 
- Take any of the options that can be enabled/disabled  (Airplane mode, Geolocation, NFC etc.)
Example taken: USB storage option.
If disabled (grey color), try swiping from the left to right.
If enabled ( blue color), try swiping from the right to the left. 


Actual results:

Nothing.


Expected results:

If disabled (grey color) on touchmove, the slider should have moved from the left to the right and stop when reaching the end of the input and turn blue (activation).
If enabled ( blue color), on touchmove, the slider should have moved from the right to the left and stop when reaching the start of the input and turn grey (deactivation).
Summary: Touch events not supported on the settings page → Touch events not supported in the settings app
Attached patch WIPSplinter Review
I would like to work on that feature but I need the visual for the animation when swiping.
Attachment #8444140 - Flags: feedback?(padamczyk)
Mentor: 21
Przemek should be able to provide this for you.
Flags: needinfo?(pabratowski)
Do you have a link to a github repo? I am not a developer so I can't review you code, but I can review the UX.
Flags: needinfo?(lalabelle03)
I believe Peter La has the animation for this 2.0 on/off toggle control.
Flags: needinfo?(pabratowski) → needinfo?(pla)
Hi there,

Thanks for contributing!  I'm attaching a video that shows the animation that was originally spec'd for 1.3.  I'll also attach photoshop assets you can use to help make it happen.

Please also talk to Casey Yee - because as far as I can remember, he has already done some work on this, and it might be beneficial to leverage what code he has already written.

Peter
Flags: needinfo?(pla) → needinfo?(kyee)
Sorry, I'm not quite awake yet. :)  Of course the animation code is already there.  Casey, ignore my needinfo.
Flags: needinfo?(kyee)
(In reply to Patryk Adamczyk [:patryk] UX from comment #3)
> Do you have a link to a github repo? I am not a developer so I can't review
> you code, but I can review the UX.

Hey, hello Peter
Thanks for your comments.
It's gonna be the first time that I contribute for an Open source project so, a bit excited to start.
I didn't push it yet to my Github repo. For the moment, I attached the draft work I did in local to this bug.
Plus, what I did for the moment it's just adding the feature that detects (it prints text for the moment soo... In progress) when the user starts touching then move then stop.
Flags: needinfo?(lalabelle03)
(In reply to Peter La from comment #5)
> Created attachment 8444474 [details]
> Animation_OnOffToggle.mov
> 
> Hi there,
> 
> Thanks for contributing!  I'm attaching a video that shows the animation
> that was originally spec'd for 1.3.  I'll also attach photoshop assets you
> can use to help make it happen.
> 
> Please also talk to Casey Yee - because as far as I can remember, he has
> already done some work on this, and it might be beneficial to leverage what
> code he has already written.
> 
> Peter

Thanks for the infos. I guess that I should see with Casey Yee then.
I don't know the entire process now, so I'll just ask to Casey if he agrees to let me know what have been done so far for that feature and if I can help. 
And Peter, will you attach the photoshop assets to this conversation?
Flags: needinfo?(kyee)
(In reply to lalabelle03 from comment #8)
> (In reply to Peter La from comment #5)
> > Created attachment 8444474 [details]
> > Animation_OnOffToggle.mov
> > 
> > Hi there,
> > 
> > Thanks for contributing!  I'm attaching a video that shows the animation
> > that was originally spec'd for 1.3.  I'll also attach photoshop assets you
> > can use to help make it happen.
> > 
> > Please also talk to Casey Yee - because as far as I can remember, he has
> > already done some work on this, and it might be beneficial to leverage what
> > code he has already written.
> > 
> > Peter
> 
> Thanks for the infos. I guess that I should see with Casey Yee then.
> I don't know the entire process now, so I'll just ask to Casey if he agrees
> to let me know what have been done so far for that feature and if I can
> help. 
> And Peter, will you attach the photoshop assets to this conversation?

Sorry lalabelle - I wasn't quite awake when I wrote this comment. :)  The animation is already in the code (since 1.3 release), and all the assets that are necessary are in gaia.  I'm not sure that you really need the PSD source to accomplish what you want.  I'll attach it anyway though.  One Sec.
Attachment #8444140 - Flags: feedback?(padamczyk)
lalabelle, The switch component does not have the drag behavior but that was something that we were working on getting into the new switch web component for 2.1 along with a visual refresh of the control.   

There has been some discussion as well about the behavior since it could in some cases interfere with the edge gestures that are being implemented.
Flags: needinfo?(kyee)
Ok so no need work on that for the moment Casey?
Firefox OS is not being worked on
Status: UNCONFIRMED → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: