1028789 - [Sora]There is no character counter inside STK submenus

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P2)

Description

[sync-1]

DEFECT DESCRIPTION:
 When accessing some STK menu that offers a field to enter some characters, none character counter is presented in order to let user know about how much characters can be used or to help user to know how many characters still left to enter.
 
  REPRODUCING PROCEDURES:
 1. Access phone settings then select STK menu (VIVO chip - at the end of list);
 2. Notice a lot of sub menus are presented;
 3. Select any submenu (e.g.: Mensagens);
 4. Notice a field to enter some text is presented;
 5. Starting inserting some text;
 6. Notice there is no character counter in order to let user know about how many characters has been inserted and how many characters user still can insert.
 
 *This feature (character counter) is important because in some submenus user is able to insert a limited qty of charatcers and a counter is needed in order to let user know about how many characters still can use.
 **There is another situation, when inserting some DATE, STK menu allow the format DDMMYY in some submenus and DDMMYYYY in other submenus, user needs to know if the submenu is about to allow DDMMYY or DDMMYYYY, in this case, only a character counter can help user.
 
  EXPECTED BEHAVIOUR:
 Phone must show a character counter everytime that phone presents a STK screen that user should insert some characters
 
  ASSOCIATE SPECIFICATION:
 None
 
  TEST PLAN REFERENCE:
 Pre homo vivo
 
  TOOLS AND PLATFORMS USED:
 STK menu
 
  USER IMPACT:
 Will see
 
  REPRODUCING RATE:
 100%
 
  For FT PR, Please list reference mobile's behavior:

Comment 1

[xiaokang.chen]

Dear Fernando,
Block VIVO again...Can you provide a proposed patch for this? Thanks a lot!

Comment 2

[xiaokang.chen]

Dear Fernando,
Any update about this? Vivo is pushing us.

Comment 3

[Beatriz Rodríguez [:brg]]

This is a new feature request out of 1.1. and very late for 1.3. IMHO we should introduce it in 2.0 and try a certification waiver for it. Do you think it is possible?

Comment 4

[Preeti Raghunath(:Preeti)]

Cert-waiver from 1.1 so please check if its possible to fix in 2.0

Comment 5

[Maria Angeles Oteo (:oteo)]

Setting ni to Rafa as we need UX feedback about how implement this feature

Comment 6

[Rafael Rebolleda]

We're very constrained in terms of space in these sort of screens. I don't think it's always necessary two explicitly show a character counter, but let me know if that's a certification request. Otherwise, other means might cover most use cases.

I see the following as possible enhancements:

* Use the text field placeholder to display input requirements, e.g.: "DDMMYYYY", "6 characters", etc.
* Bouncing animation left/right on the textfield when the user tries to enter more chars than allowed (the [send] button is disabled when not enough chars have been entered)
* Use the [ok]/[send] button to convey some info by changing its state from disabled to, for example, red.
* In addition to changing states, the [send] button could hold the counter.
* Reduce the text field's width and display a counter on its side (I'd really like to avoid this one)


Hope those help!

Comment 7

[Beatriz Rodríguez [:brg]]

Yes, this is a must for certification, lets include it asap.

Comment 8

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Attachment: Proposed patch

Proposed patch.

As Rafa suggested me, now the keyboard is not hidden when the input box is plenty.

Also an animation and mobile vibration is applied as a feedback when no more characters allowed.

The Ok buttons shows the pending number of characteres.

Comment 9

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 8447945 [details] [review]
Proposed patch

r+ with nits.

Comment 10

[Carmen Jimenez Cabezas]

https://github.com/mozilla-b2g/gaia/commit/f00fdf04461d7f30a6c1be95be11bb656da7fa6f

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Needs rebasing for v2.0 uplift.

Comment 12

[Carmen Jimenez Cabezas]

rebasing for v2.0 uplift:
https://github.com/mozilla-b2g/gaia/pull/21616 

waiting for travis merge

Comment 13

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/e984b534020687a89ce749af6c2e5f4ae28c54ae

Comment 14

[Loli (:lolimartinezcr)]

Attachment: 2014-08-12-03-50-47.png

Comment 15

[Loli (:lolimartinezcr)]

Tested and working (see attached image)
Hamachi
2.1
Gecko-329b2e4
Gaia-d688d4f

2.0
Gecko-d7d9838
Gaia-1144cdc