1028808 - Inconsistent spelling of "Homescreen" across Gaia apps

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia, defect)

Description

[Francesco Lodolo [:flod]]

I noticed that we're completely inconsistent with the spelling of this element.

http://transvision.mozfr.org/?recherche=home+screen&repo=gaia&sourcelocale=en-US&locale=en-US&search_type=strings

Available variants:
* Home Screen
* Homescreen
* homescreen
* home screen

There's no need to change the ID of these strings, just decide which one is right and stick to it.

Comment 1

[Matej Novak [:matej]]

This should be "home screen" (only capitalized when at the beginning of a sentence).

Thanks.

Comment 2

[Théo Chevalier]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/21423

Hi Matej,

Any chance you can give it a quick look?

Especially because I'm not sure about the capitalization in this sentence:

Search suggestions are shown as you type. Go to the home screen section of Settings to change your search preferences.

Comment 3

[Matej Novak [:matej]]

Hi Théo,

I'm not very good at GitHub, but the example you have in comment 2 is correct.

Thanks.

Comment 4

[Francesco Lodolo [:flod]]

I'd also suggest to send a mail to dev-gaia when done, and point developers to Transvision to check existing strings in Gaia.

Comment 5

[Théo Chevalier]

Thanks Matej!

Good idea flod, will do.

Also, not sure if breaking tests or not: https://travis-ci.org/mozilla-b2g/gaia/jobs/29278492#L3244
In tests/python/gaia-ui-tests/gaiatest/tests/functional/homescreen/test_homescreen_launch_app.py self.APP_NAME = 'Mozilla QA WebRT Tester'. I guess the cause is the timeout?

Comment 6

[Théo Chevalier]

Comment on attachment 8451397 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/21423

Re-ran Travis, got different failure, guess it's not my fault :)

Tim, could you review this one for me please?
(More or less rubber-stamping, sorry about that)

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8451397 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/21423

I am not sure if you have kill all the instances of incorrect "home screen",but r+.

You should also post on dev-gaia and ask everyone stop checking-in incorrect strings!

Bugzilla component name might need a correction too -- I am pretty sure people will keep typing Homescreen if they see this every day.

Comment 8

[Théo Chevalier]

Thanks Tim.
I haven't updated the strings in .html files because it's never displayed, but I can if needed.

Comment 9

[Théo Chevalier]

Rebased to fix the string that just landed in Bug 1031254.
Ready to go!

Comment 10

[Théo Chevalier]

Message sent to dev.gaia https://groups.google.com/d/msg/mozilla.dev.gaia/bDloq6f-4qw/3xTYcRYEGJoJ

Comment 11

[Théo Chevalier]

Actually breaking some tests.

Comment 12

[Théo Chevalier]

Fixed the tests, got a green run https://tbpl.mozilla.org/?tree=Gaia-Try&rev=b0bd068af9ef

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/b41c4a8f90e80501a4095c232e79016b2bc196ea

Comment 14

[Zac C (:zac)]

Flod, this has created a really weird effect; On device we are seeing the displayed app as 'homescreen' but on desktopb2g (eg CI) it is reported as 'home screen'. The displayed app name comes via the AppWindowManager.

We can't use the same test for both platforms because of this anomaly.

Comment 15

[Axel Hecht [:Pike]]

Zac, can you add more detail? For one, what's the exact test that produces the result, and also, is upper-lower-case exactly like you report it? I'm asking because I'd expect "Home screen" instead of "home screen" on at least one side.

Also, is this the tests seeing things, or is a human seeing this, too? The reason for this is to make sure we're not falling for race conditions here.

Comment 16

[Zac C (:zac)]

STR:
1. Flash device with latest build
2. Connect with App Manager (in Nightly)
3. Probe the system app
4. Using console, check: window.AppWindowManager.getActiveApp().name

> window.AppWindowManager.getActiveApp().name
> "Homescreen"

Build under test:
Device Flame
Gaia      da6971cdfb88985ec84d44262bccc25b3100d5de
Gecko     https://hg.mozilla.org/integration/b2g-inbound/rev/8d7a7dbc6c51
BuildID   20140715005635
Version   33.0a1
ro.build.version.incremental=eng.cltbld.20140624.101744
ro.build.date=Tue Jun 24 10:17:54 EDT 2014

Comment 17

[Zac C (:zac)]

Axel, ignore the case (our test framework normalises all to lower case)..

Check the STR, that should help. If you'd like the same STR on desktopb2g I'll try and work something out.

Comment 18

[Zac C (:zac)]

Same on desktopb2g (as used by CI)

>>> m.execute_script('return window.wrappedJSObject.AppWindowManager.getActiveApp().name')
u'Home screen'

Build ID 20140715021236
downloaded from:
http://ftp.mozilla.org/pub/mozilla.org/b2g/tinderbox-builds/b2g-inbound-linux64_gecko/1405418975/

Comment 19

[Francesco Lodolo [:flod]]

(In reply to Zac C (:zac) from comment #16)
> STR:
> 1. Flash device with latest build
> 2. Connect with App Manager (in Nightly)
> 3. Probe the system app
> 4. Using console, check: window.AppWindowManager.getActiveApp().name

I'm getting "Home screen" here (first phone set to Italian, then English).

12:46:12.312 console.log(window.AppWindowManager.getActiveApp().name);
12:46:12.316 undefined
12:46:19.392 window.AppWindowManager.getActiveApp().name
12:46:19.391 "Schermata principale"
12:47:33.761 window.AppWindowManager.getActiveApp().name
12:47:33.764 "Home screen"

Comment 20

[Axel Hecht [:Pike]]

Zac, do you have a multi-locale build set up with the gaia-l10n/en-US repo in place?

You could hit bug 1007485

Comment 21

[Zac C (:zac)]

I am just using straight off builds straight off b2g-i TBPL and pvt, no extra flashing of Gaia.

This is also failing on our Jenkins device testing array too so it's not isolated to my device.

Comment 22

[Zac C (:zac)]

I've just flashed my device back and forth through a few different builds to try and work out the difference but now it is working again. I've no idea why.

However it is still failing on our Jenkins instance, see this HTML report (note the commit at the top of the report which confirms this commit is in that build)
http://jenkins1.qa.scl3.mozilla.com/job/flame.b2g-inbound.ui.functional/64/HTML_Report/

Comment 23

[Francesco Lodolo [:flod]]

Flashed from pvt

12:58:37.078 window.AppWindowManager.getActiveApp().name
17:53:31.979 "Homescreen"

Gaia      f31f95ec18882decc43c0e2f02df581580a32dc8
Gecko     https://hg.mozilla.org/mozilla-central/rev/2bb155ee786b
BuildID   20140714160204
Version   33.0a1
ro.build.version.incremental=94
ro.build.date=Tue May 20 09:29:20 CST 2014
B1TC200110G0

So I tried
adb pull /system/b2g/webapps/homescreen.gaiamobile.org/manifest.webapp

And found in it:
en-US":{"name":"Homescreen","description":"Gaia Homescreen"}

So I think it's actually bug 1007485 hitting us.
https://hg.mozilla.org/gaia-l10n/en-US/file/5fdeadc7e9c5/apps/homescreen/manifest.properties

Comment 24

[Zac C (:zac)]

I tried the above comment #32 and I can replicate that too.

Comment 25

[Zac C (:zac)]

flod, can we back this out and make bug 1007485 dependent?

Comment 26

[Francesco Lodolo [:flod]]

You're asking the wrong person (not the patch author, no rights whatsoever on Gaia) ;-)

It also depends on how long we can live with this, how long it will take bug 1007485 to land, or if we can temporarily disable the failing test while we wait.

Comment 27

[Ryan VanderMeulen [:RyanVM]]

Reverted at Zac's request over IRC.

Master: https://github.com/mozilla-b2g/gaia/commit/5a8be7da1874e3ff3c1e2ca1caa8746c5a97d40b