Closed
Bug 1028843
Opened 10 years ago
Closed 10 years ago
Improve wait for b2g to be resistant to JavaScript exceptions
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect)
Tracking
(b2g-v1.3 fixed, b2g-v1.3T fixed)
RESOLVED
FIXED
People
(Reporter: davehunt, Assigned: davehunt)
References
Details
Attachments
(1 file)
+++ This bug was initially created as a clone of Bug #1028152 +++ The performance tests have recently picked up a couple of non-fatal JavaScript exceptions during boot. Let's see if we can uplift a v1.3 safe version of the improved wait that doesn't rely on asynchronous JavaScript.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8444341 -
Flags: review?(zcampbell)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8444341 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20886 r- , missing a closing bracket in the javascript.
Attachment #8444341 -
Flags: review?(zcampbell) → review-
|
|
Assignee | |
Comment 3•10 years ago
|
||
Comment on attachment 8444341 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20886 Thanks. I had fixed the syntax error in my iPython script but forgot to fix it in my patch. It's updated now.
Attachment #8444341 -
Flags: review- → review?(zcampbell)
|
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8444341 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20886 r+, works nicely.
Attachment #8444341 -
Flags: review?(zcampbell) → review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
Landed in: https://github.com/mozilla-b2g/gaia/commit/7a25ded52cf1164196098545be4fa7d5111fd526
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
||
Updated•10 years ago
|
status-b2g-v1.3:
--- → fixed
status-b2g-v1.3T:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•