Closed Bug 1028860 Opened 10 years ago Closed 10 years ago

Implement animation for adding apps to collections

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Homescreen
Platform:
x86
Windows 8.1
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.0 verified, b2g-v2.1 verified)

Status:
VERIFIED FIXED
Milestone:
2.0 S5 (4july)
Tracking Flags:
Tracking Status
b2g-v2.0 --- verified
b2g-v2.1 --- verified

People

(Reporter: cwiiis, Assigned: cwiiis)

References

Details

(Whiteboard: [systemsfe])

Attachments

(2 files)

Add animation for dropping an app on to a collection in verticalhome
46 bytes, text/x-github-pull-request
kgrandon
: review+
bajaj
: approval-gaia-v2.0+
Details | Review
Verified video: verify_1028860.MP4
2.03 MB, video/mp4
Details 
Adding apps to collections doesn't animate as UX desired in bug 991460. The animation should be the dropped icon shrinking into the collection and the original icon growing back into place simultaneously.
Depends on: 991460
QA Whiteboard: [VH-FL-blocking-][VH-FC-blocking?]
Need UX to make a call if this is a blocker or not for 2.0.
Blocks: 1015336
Flags: needinfo?(firefoxos-ux-bugzilla)
Flagging Francis for final call but my initial one is not to block.
Flags: needinfo?(firefoxos-ux-bugzilla) → needinfo?(fdjabri)
Comment on attachment 8444336 [details] [review]
Add animation for dropping an app on to a collection in verticalhome

Nice work! I made a few comments on github, I do think we should keep bookmark into collection support for now even though it's broken - just so we don't have to create a follow-up to re-enable.
Attachment #8444336 - Flags: review?(kgrandon) → review+
Merged: http://git.io/I_fOtg
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
status-b2g-v2.0: --- → affected
status-b2g-v2.1: --- → fixed
Comment on attachment 8444336 [details] [review]
Add animation for dropping an app on to a collection in verticalhome

This is needed for the vertical homescreen.
Attachment #8444336 - Flags: approval-gaia-v2.0?(bbajaj)
Attachment #8444336 - Flags: approval-gaia-v2.0?(bbajaj) → approval-gaia-v2.0+
v2.0: https://github.com/mozilla-b2g/gaia/commit/fe5d10bcfb7a04ee11051a0183d2524dc67d890e

Please post a link to the final Gaia changeset in the future. Makes uplifts a bit easier.
status-b2g-v2.0: affected → fixed
Target Milestone: --- → 2.0 S5 (4july)
Flags: needinfo?(fdjabri)
Whiteboard: [systemsfe]
This issue has been verified successfully on Flame2.0&2.1
Verify video:"verify_1028860.mp4".

Flame2.0 build
Gaia-Rev        856863962362030174bae4e03d59c3ebbc182473
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/e40fe21e37f1
Build-ID        20141208000206
Version         32.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141208.035628
FW-Date         Mon Dec  8 03:56:38 EST 2014
Bootloader      L1TC00011880

Flame 2.1 build:
Gaia-Rev        38e17b0219cbc50a4ad6f51101898f89e513a552
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/8b92c4b8f59a
Build-ID        20141205001201
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141205.035305
FW-Date         Fri Dec  5 03:53:16 EST 2014
Bootloader      L1TC00011880
Status: RESOLVED → VERIFIED
status-b2g-v2.0: fixed → verified
status-b2g-v2.1: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: