Closed Bug 1028885 Opened 6 years ago Closed 6 years ago
Reposition three-dot menu from tabs tray on device rotation
47.58 KB, image/png
51.56 KB, image/png
1.21 KB, patch
|Details | Diff | Splinter Review|
Environment: Nightly (2014-06-23) Device: Asus Transformer Pad TF300T(Android 4.2.1) Steps to reproduce: 1. Launch Fennec; 2. Open tabs tray menu; 3. Tap on 3-dot menu; 4. Rotate the device. Notes: See attachment.
Assignee: nobody → margaret.leibovic
tracking-fennec: ? → 33+
This seems to work fine on both the Nexus 10 (4.4.3) and my Asus Transformer 1 (4.0.3). Is this still reproducible, Cristina?
Oh, derp, I reversed a step in the STR. Clearing needinfo.
We're already handling changing the anchor on device rotation, but we don't update the position of the popup if it's already open (the anchor is only referenced in the showAsDropDown call). This fixes that.
Attachment #8465799 - Flags: review?(wjohnston)
Attachment #8465799 - Flags: review?(wjohnston) → review+
Comment on attachment 8465799 [details] [diff] [review] Reposition open tabs tray menu on device rotation Approval Request Comment [Feature/regressing bug #]: bug 817716 [User impact if declined]: Tabs menu is misplaced on tablets when device is rotated. [Describe test coverage new/current, TBPL]: No automated test coverage for this particular edge case. Tested locally and just landed on fx-team. [Risks and why]: Low-risk, adds small bit of logic to re-show menu when device is rotated. [String/UUID change made/needed]: none
Attachment #8465799 - Flags: approval-mozilla-aurora?
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
Attachment #8465799 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified as fixed in Builds: Firefox for Android Nightly 34.0a1 (2014-08-07) Firefox for Android Aurora 33.0a2 (2014-08-08) Device: Asus Transformer Pad TF300T (Android 4.2.1)
You need to log in before you can comment on or make changes to this bug.