1028885 - Reposition three-dot menu from tabs tray on device rotation

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Cristina Madaras, QA [:CristinaM]]

Attachment: from_landscape_in_portrait.png

Environment:
Nightly (2014-06-23)
Device: Asus Transformer Pad TF300T(Android 4.2.1)

Steps to reproduce:
1. Launch Fennec;
2. Open tabs tray menu;
3. Tap on 3-dot menu;
4. Rotate the device.

Notes: See attachment.

Comment 1

[Cristina Madaras, QA [:CristinaM]]

Attachment: from_portrait_in_landscape.png

Comment 2

[Chenxia Liu [:liuche]]

Attachment: Screenshot: Nexus 10 4.4.3

This seems to work fine on both the Nexus 10 (4.4.3) and my Asus Transformer 1 (4.0.3).

Is this still reproducible, Cristina?

Comment 3

[Chenxia Liu [:liuche]]

Oh, derp, I reversed a step in the STR. Clearing needinfo.

Comment 4

[:Margaret Leibovic]

Attachment: Reposition open tabs tray menu on device rotation

We're already handling changing the anchor on device rotation, but we don't update the position of the popup if it's already open (the anchor is only referenced in the showAsDropDown call). This fixes that.

Comment 5

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/353e97284fd0

Comment 6

[:Margaret Leibovic]

Comment on attachment 8465799 [details] [diff] [review]
Reposition open tabs tray menu on device rotation

Approval Request Comment
[Feature/regressing bug #]: bug 817716
[User impact if declined]: Tabs menu is misplaced on tablets when device is rotated.
[Describe test coverage new/current, TBPL]: No automated test coverage for this particular edge case. Tested locally and just landed on fx-team.
[Risks and why]: Low-risk, adds small bit of logic to re-show menu when device is rotated.
[String/UUID change made/needed]: none

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/353e97284fd0

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/013fd839967c

Comment 9

[Cristina Madaras, QA [:CristinaM]]

Verified as fixed in
Builds:
Firefox for Android Nightly 34.0a1 (2014-08-07)
Firefox for Android Aurora 33.0a2 (2014-08-08)

Device: Asus Transformer Pad TF300T (Android 4.2.1)