Closed Bug 1028885 Opened 6 years ago Closed 6 years ago

Reposition three-dot menu from tabs tray on device rotation

Categories

(Firefox for Android :: General, defect)

33 Branch
ARM
Android
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 34
Tracking Status
firefox32 --- unaffected
firefox33 --- verified
firefox34 --- verified
fennec 33+ ---

People

(Reporter: CristinaM, Assigned: Margaret)

References

Details

Attachments

(3 files, 1 obsolete file)

Environment:
Nightly (2014-06-23)
Device: Asus Transformer Pad TF300T(Android 4.2.1)

Steps to reproduce:
1. Launch Fennec;
2. Open tabs tray menu;
3. Tap on 3-dot menu;
4. Rotate the device.

Notes: See attachment.
Blocks: 817716
tracking-fennec: --- → ?
Assignee: nobody → margaret.leibovic
tracking-fennec: ? → 33+
Attached image Screenshot: Nexus 10 4.4.3 (obsolete) —
This seems to work fine on both the Nexus 10 (4.4.3) and my Asus Transformer 1 (4.0.3).

Is this still reproducible, Cristina?
Flags: needinfo?(cristina.madaras)
Oh, derp, I reversed a step in the STR. Clearing needinfo.
Flags: needinfo?(cristina.madaras)
Attachment #8447509 - Attachment is obsolete: true
We're already handling changing the anchor on device rotation, but we don't update the position of the popup if it's already open (the anchor is only referenced in the showAsDropDown call). This fixes that.
Attachment #8465799 - Flags: review?(wjohnston)
Attachment #8465799 - Flags: review?(wjohnston) → review+
Comment on attachment 8465799 [details] [diff] [review]
Reposition open tabs tray menu on device rotation

Approval Request Comment
[Feature/regressing bug #]: bug 817716
[User impact if declined]: Tabs menu is misplaced on tablets when device is rotated.
[Describe test coverage new/current, TBPL]: No automated test coverage for this particular edge case. Tested locally and just landed on fx-team.
[Risks and why]: Low-risk, adds small bit of logic to re-show menu when device is rotated.
[String/UUID change made/needed]: none
Attachment #8465799 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/353e97284fd0
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
Attachment #8465799 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified as fixed in
Builds:
Firefox for Android Nightly 34.0a1 (2014-08-07)
Firefox for Android Aurora 33.0a2 (2014-08-08)

Device: Asus Transformer Pad TF300T (Android 4.2.1)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.