Closed Bug 1028887 Opened 7 years ago Closed 7 years ago

Autoclosing a Sqlite.jsm database should cause tests to fail

Categories

(Toolkit :: Async Tooling, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: Yoric, Assigned: brennan.brisad)

References

Details

Attachments

(1 file, 1 obsolete file)

Bug 939072 introduces auto-closing of Sqlite.jsm databases. This prints a warning. We should also ensure that this causes tests to fail.

For this purpose, it would be sufficient to insert an (uncatchable) `Promise.reject` whenever we autoclose a database.
Do you want to handle this, Michael?
Flags: needinfo?(brennan.brisad)
Sure, I'd be happy to.
Flags: needinfo?(brennan.brisad)
Assignee: nobody → brennan.brisad
Attached patch Cause tests to fail on autoclose (obsolete) — Splinter Review
Attachment #8446018 - Flags: review?(dteller)
Comment on attachment 8446018 [details] [diff] [review]
Cause tests to fail on autoclose

Review of attachment 8446018 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, with the minor nit below
If this kills existing tests, of course, you'll need to fix them, too.

::: toolkit/modules/Sqlite.jsm
@@ +57,5 @@
>    consoleMessage.init(message, stack.fileName, null, stack.lineNumber, 0,
>                        Ci.nsIScriptError.errorFlag, "component javascript");
>    Services.console.logMessage(consoleMessage);
>  
> +  if (Debugging.failTestsOnAutoClose) {

Could you add a comment explaining why you do this?
Attachment #8446018 - Flags: review?(dteller) → review+
Added comment mentioned in review. No other tests failed.
Attachment #8446018 - Attachment is obsolete: true
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/3a1f1bf7edb9
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.