1028887 - Autoclosing a Sqlite.jsm database should cause tests to fail

Status: RESOLVED FIXED

(Toolkit :: Async Tooling, defect)

Description

[David Teller [:Yoric] - still alive but not very active]

Bug 939072 introduces auto-closing of Sqlite.jsm databases. This prints a warning. We should also ensure that this causes tests to fail.

For this purpose, it would be sufficient to insert an (uncatchable) `Promise.reject` whenever we autoclose a database.

Comment 1

[David Teller [:Yoric] - still alive but not very active]

Do you want to handle this, Michael?

Comment 2

[Michael Hoffmann]

Sure, I'd be happy to.

Comment 3

[Michael Hoffmann]

Attachment: Cause tests to fail on autoclose

Comment 4

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 8446018 [details] [diff] [review]
Cause tests to fail on autoclose

Review of attachment 8446018 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, with the minor nit below
If this kills existing tests, of course, you'll need to fix them, too.

::: toolkit/modules/Sqlite.jsm
@@ +57,5 @@
>    consoleMessage.init(message, stack.fileName, null, stack.lineNumber, 0,
>                        Ci.nsIScriptError.errorFlag, "component javascript");
>    Services.console.logMessage(consoleMessage);
>  
> +  if (Debugging.failTestsOnAutoClose) {

Could you add a comment explaining why you do this?

Comment 5

[Michael Hoffmann]

Attachment: Cause tests to fail on autoclose v2

Added comment mentioned in review. No other tests failed.

Comment 6

[Michael Hoffmann]

Try: https://tbpl.mozilla.org/?tree=Try&rev=1590b74e4692

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3a1f1bf7edb9

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3a1f1bf7edb9