Closed
Bug 1028933
Opened 11 years ago
Closed 11 years ago
Hide the context menu ui when the homescreen is not visible
Categories
(Firefox OS Graveyard :: Gaia::Homescreen, defect)
Firefox OS Graveyard
Gaia::Homescreen
Tracking
(tracking-b2g:backlog, b2g-v2.0 fixed, b2g-v2.1 fixed)
People
(Reporter: vingtetun, Assigned: vingtetun)
References
Details
(Whiteboard: [systemsfe])
Attachments
(1 file)
|
4.94 KB,
patch
|
kgrandon
:
review+
bajaj
:
approval-gaia-v2.0+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8444431 -
Flags: review?(kgrandon)
|
||
Updated•11 years ago
|
QA Whiteboard: [VH-FL-blocking-][VH-FC-blocking-]
|
|
||
Updated•11 years ago
|
QA Whiteboard: [VH-FL-blocking-][VH-FC-blocking-] → [VH-FL-blocking-][VH-FC-blocking?]
|
||
Updated•11 years ago
|
Whiteboard: [systemsfe]
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8444431 [details] [diff] [review]
bug1028933.patch
Review of attachment 8444431 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM.
Attachment #8444431 -
Flags: review?(kgrandon) → review+
|
|
||
Updated•11 years ago
|
Assignee: nobody → 21
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 4•11 years ago
|
||
(In reply to Jason Smith [:jsmith] from comment #3)
> What's the user impact of this bug if we don't fix it?
Same comment as https://bugzilla.mozilla.org/show_bug.cgi?id=1028940#c4
Flags: needinfo?(21)
|
|
||
Updated•11 years ago
|
QA Whiteboard: [VH-FL-blocking-][VH-FC-blocking?] → [VH-FL-blocking-][VH-FC-blocking+]
|
||
Comment 5•11 years ago
|
||
Moving this to backlog doesn't classify a blocker
blocking-b2g: 2.0? → backlog
|
|
||
Comment 6•11 years ago
|
||
(In reply to Preeti Raghunath(:Preeti) from comment #5)
> Moving this to backlog doesn't classify a blocker
Minor user impact.
|
|
||
Updated•11 years ago
|
QA Whiteboard: [VH-FL-blocking-][VH-FC-blocking+] → [VH-FL-blocking-][VH-FC-blocking-]
|
|
Assignee | |
Comment 7•11 years ago
|
||
|
|
Assignee | |
Comment 8•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
||
Comment 9•11 years ago
|
||
Comment on attachment 8444431 [details] [diff] [review]
bug1028933.patch
Review of attachment 8444431 [details] [diff] [review]:
-----------------------------------------------------------------
This is needed for the vertical homescreen.
Attachment #8444431 -
Flags: approval-gaia-v2.0?(bbajaj)
|
||
Updated•11 years ago
|
Attachment #8444431 -
Flags: approval-gaia-v2.0?(bbajaj) → approval-gaia-v2.0+
|
||
Comment 10•11 years ago
|
||
|
|
||
Comment 11•11 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #10)
> v2.0:
> https://github.com/mozilla-b2g/gaia/commit/
> 7edc43f1eecefa612fc28f0982c55a2bd16555e4
Whoops, pasted the wrong link there.
v2.0: https://github.com/mozilla-b2g/gaia/commit/f710da88b402d54a0f5461bc2253eed0b1bd652e
|
||
Updated•10 years ago
|
blocking-b2g: backlog → ---
tracking-b2g:
--- → backlog
You need to log in
before you can comment on or make changes to this bug.
Description
•