Closed Bug 1028942 Opened 7 years ago Closed 7 years ago

The 'Translate' button's border looks blurry on Mac

Categories

(Firefox :: Translation, defect)

x86
macOS
defect
Not set
normal
Points:
1

Tracking

()

VERIFIED FIXED
Firefox 33
Iteration:
33.2
Tracking Status
firefox32 --- verified
firefox33 --- verified

People

(Reporter: florian, Assigned: smacleod)

References

Details

(Whiteboard: [translation])

Attachments

(3 files)

Attached image Screenshot
The border of the 'Translate' button isn't satisfying. I remember Sevaan said on IRC it wasn't looking as designed, but I don't remember if/where we have a clear specification of how it should look. Sevaan, do you have the specification of how that border should be?
Flags: needinfo?(sfranks)
Looping in button guru Michael Maslaney.
Flags: needinfo?(sfranks) → needinfo?(mmaslaney)
(In reply to Florian Quèze [:florian] [:flo] from comment #0)
> Created attachment 8444435 [details]
> Screenshot
> 
> The border of the 'Translate' button isn't satisfying. I remember Sevaan
> said on IRC it wasn't looking as designed, but I don't remember if/where we
> have a clear specification of how it should look. Sevaan, do you have the
> specification of how that border should be?

Florian, here is the original spec provided, with CSS in the source code: https://people.mozilla.org/~sfranks/Translation/buttons_old.html
Flags: needinfo?(mmaslaney)
Assignee: nobody → smacleod
Status: NEW → ASSIGNED
Iteration: --- → 33.2
QA Whiteboard: [qa+]
Flags: firefox-backlog+
QA Contact: bogdan.maris
Hi Steven, checking in if you have an idea of the point value for this bug?
Flags: needinfo?(smacleod)
(In reply to Marco Mucci [:MarcoM] from comment #3)
> Hi Steven, checking in if you have an idea of the point value for this bug?
Hey Marco, sorry about the delay. I've marked it a 1
Points: --- → 1
Flags: needinfo?(smacleod)
Whiteboard: [translation]
Some of the styling for the "Not Now" button was being shared between both buttons. I've moved these styles out of the common button rules.
Attachment #8447354 - Flags: review?(florian)
Attached image Screenshot - Post Patch
Here is a screenshot with the patch applied.
Comment on attachment 8447354 [details] [diff] [review]
Patch - Fix 'Translate' button border on OSX.

Thanks Steven. This is something we should uplift for the trial.

Approval Request Comment
[Feature/regressing bug #]: This bug is part of the automatic translation feature, which we want to A/B with a subset of Aurora 32 users, and later Beta 32 users.
[User impact if declined]: The 'Translate' button of the translation infobar will have ugly borders on Mac.
[Describe test coverage new/current, TBPL]: none.
[Risks and why]: almost none, trivial CSS-only change.
[String/UUID change made/needed]: none.
Attachment #8447354 - Flags: review?(florian)
Attachment #8447354 - Flags: review+
Attachment #8447354 - Flags: approval-mozilla-aurora?
Comment on attachment 8447354 [details] [diff] [review]
Patch - Fix 'Translate' button border on OSX.

Aurora approval granted.
Attachment #8447354 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/mozilla-central/rev/a031c620067b
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 33
Hi Bogdan, the desktop iteration ends on Monday.  Is it possible to have this bug verified by then.
Flags: needinfo?(bogdan.maris)
(In reply to Marco Mucci [:MarcoM] from comment #12)
> Hi Bogdan, the desktop iteration ends on Monday.  Is it possible to have
> this bug verified by then.

Sure.
Verified that the 'Translate' button border doesn`t look blurry anymore on Mac OS X 10.9.4 and Mac OS X 10.8.5 using latest Nightly and latest Aurora.
Status: RESOLVED → VERIFIED
QA Whiteboard: [qa+] → [qa!]
Flags: needinfo?(bogdan.maris)
You need to log in before you can comment on or make changes to this bug.