1028971 - [Vertical Homescreen] Smart Collection does not load anymore if you put a browser bookmark inside it

Status: RESOLVED DUPLICATE of bug 1028681

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Johan Lorenzo [:jlorenzo]]

STR
1. Create a new Smart Collection.
2. Open it. Verify that the content is loaded.
3. Add a browser bookmark on the Homescreen.
4. Add the bookmark into the Smart Collection created in step 1.
5. Open the Smart Collection

Actual result
The Smart Collection shows indefinitely a loading screen.

Reproducibility rate : 3/3

Comment 1

[Johan Lorenzo [:jlorenzo]]

Standard user path.

Comment 2

[Chris Lord [:cwiiis]]

I believe this is because we only actually support adding apps to the collection, but we don't check during drag and drop if you're dragging an app. This is coincidentally fixed in bug 1028860, but I can split it out into a separate patch if we'd prefer.

Comment 3

[James Lal [:lightsofapollo]]

Seeing this: [JavaScript Error: "TypeError: GaiaGrid.Bookmark is not a constructor" {file: "app://collection.gaiamobile.org/js/home_icons.js" line: 59}]

Comment 4

[Kevin Grandon :kgrandon]

Do we just need to add the items/bookmark.js file to the collection page? Seems like it would be nice to support this if possible.

I'm currently adding an integration test to pin apps in bug 1028681 which should land today. If we do fix this, let's add a test.

Comment 5

[Kevin Grandon :kgrandon]

Sorry, this was fixed in bug 1028681 =(