102899 - Link toolbar More and Document buttons disappear with Modern theme

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Hixie (not reading bugmail)]

STEPS TO REPRODUCE
   Switch to Modern.
   Go to a web page without links.
   Look at the Link Toolbar.
   Go to a web page with links, e.g.:
      http://www.bath.ac.uk/~py8ieh/internet/eviltests/link2.html

ACTUAL RESULTS
   While the toolbar's Document and More menu buttons are disabled, their icons
   disappear. This only happens in Modern.

EXPECTED RESULTS
   The icons should always be visible, as they are in Classic.

cc'ing usual suspects as per bug 102832.

Comment 1

[Jeffrey Baker]

I think the summary is wrong

Comment 2

[Gervase Markham [:gerv]]

This is because we renamed the images and I failed to update the CSS. The bug is in:
themes/modern/communicator/bookmarks/bookmarksToolbar.css
where *item-disabled.gif should be *item-dis.gif.

Gerv

Comment 3

[Gervase Markham [:gerv]]

Attachment: Patch v.1

Comment 4

[sairuh (rarely reading bugmail)]

cool new feature!

->claudius, since he tests toolbars.

Comment 5

[Christopher Hoess (gone)]

r=choess.

Comment 6

[Gervase Markham [:gerv]]

CCing hewitt for sr= and asa for a=. This is a trivial change to fix brokenness
which should go in irrespective of the current status of the Links toolbar.

Gerv

Comment 7

[David Hyatt]

sr=hyatt

Comment 8

[Asa Dotzler [:asa]]

Comment on attachment 51890 [details] [diff] [review]
Patch v.1

(adding hyatt's sr to the patch status)

a=asa (on behalf of drivers) for checkin to 0.9.5

Comment 9

[Gervase Markham [:gerv]]

Checked in.

Gerv

Comment 10

[Gervase Markham [:gerv]]

Doh!

Gerv

Comment 11

[Christopher Hoess (gone)]

Verified Fixed.