1029016 - [Collection app] Can't interact with pinned apps when loading web results

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Description

[Ran Ben Aharon [:ranbena] EverythingMe]

More accurate: Can't click, long press pinned apps as long as progress indicator active or connection message appears.

STR:
1. Open Collection that has pinned apps.
2. While progress indicator appears click a pinned app.

Expected: App opens.
Actual: App does not.

Comment 1

[Ran Ben Aharon [:ranbena] EverythingMe]

The cause:
The section[role="notification"] element (progress indicator and connection message elements) covers <gaia-grid>. That's because it's a flexbox that has the same z-index as <gaia-grid>.

Quick solution: set <gaia-grid>'s z-index to 2. Boom. Bug fixed.

BUT the preferred solution is to enable the element to start from the bottom of <gaia-grid>. The problem is that <gaia-grid> has no physical height because it's content is absolutely positioned. It's possible to set <gaia-grid>'s height in js using grid.scrollHeight (but that's error prone imo).

Kevin, wdyt?

Comment 2

[Kevin Grandon :kgrandon]

TBH I'm probably ok with the quick z-index hack for 2.0 Longer term, having some kind of gaia grid semantics for a "loading" state, or being able to append a progress indicator to the grid might be ideal.

Blocking bug 1017954 until deemed a blocker, but if we fix it we'll request approval to uplift.

Comment 3

[Ran Ben Aharon [:ranbena] EverythingMe]

Attachment: PR

z-index:2 solution

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8444566 [details] [review]
PR

Seems to work fine for me, thanks!

Comment 5

[Kevin Grandon :kgrandon]

Landed: https://github.com/mozilla-b2g/gaia/commit/e10a1667a57bd945a81c531b6dd9dc4f06c4db4a

Comment 6

[Kevin Grandon :kgrandon]

Comment on attachment 8444566 [details] [review]
PR

This is needed for the vertical homescreen.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/8ab6236e1c1cc2845a1742f186779bbd8190251f

Comment 8

[Elie]

Attachment: VIDEO0108_Compress.MP4

This issue has been successfully verified on Flame 2.0:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3
Build-ID        20141202000201
Version         32.0
Device-Name     flame
FW-Release      4.4.2

This issue has been successfully verified on Flame 2.1:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141202001201
Version         34.0
Device-Name     flame
FW-Release      4.4.2