1029023 - QA and push "add a mentor" to production

Status: RESOLVED FIXED

(Webmaker Graveyard :: Design & UX, defect)

Description

[Brett Gaylor [:brett]]

Attachment: Test the "add a mentor" feature

Lets do the QA and push to production in the same ticket.  Kate, push once Cassie and I have done a final review.

Comment 1

[Brett Gaylor [:brett]]

Comment on attachment 8444548 [details]
Test the "add a mentor" feature

Works for me.  Only comment is that the email should have a link to the organizers profile, I will file that as a seperate ticket.

Comment 2

[Cassie McDaniel [:cassiemc]]

(In reply to Brett Gaylor [:brett] from comment #1)
> Comment on attachment 8444548 [details]
> Test the "add a mentor" feature
> 
> Works for me.  Only comment is that the email should have a link to the
> organizers profile, I will file that as a seperate ticket.

Ideally the email is replaced with the user name, if found in the system, which then links to the profile.

Comment 3

[Cassie McDaniel [:cassiemc]]

Comment on attachment 8444548 [details]
Test the "add a mentor" feature

Looks mostly good.

* When adding a mentor I shouldn't receive the warning "you must add someone by email" until after I've hit the "+" button. Right now I am receiving it intermittently as I am typing in the email address.

* "Please note that cassiemc (the organizer of the event) will know your email address." <---This line in the confirmation email is weird and I would remove it. Once the user confirms, the organizer should only see the user name / profile link, no longer their email. 

* If I hit decline in the email, and go back and forth to that confirmation page, I receive this error message: "Sorry, this does not appear to be a valid token. Did you get here by mistake?" The word 'token' is not user-friendly, can we say 'address' or 'page'? I would actually question whether or not we need that decline link. Couldn't they just NOT reply to the email? That way, they only need to click a link in order to confirm. Not sure what declining actually does for them.

Comment 4

[Brett Gaylor [:brett]]

Also adding Cade's bug#1029056 as a blocker

Comment 5

[inactivate account for kate]

Can you file those as separate tickets if you still think those are needed?