Closed Bug 1029040 Opened 7 years ago Closed 7 years ago

[Collection app] Do not allow creation of smart collections while offline

Categories

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

x86
macOS
defect
Not set
normal

Tracking

(blocking-b2g:2.0+, b2g-v1.4 unaffected, b2g-v2.0 fixed, b2g-v2.1 fixed)

RESOLVED FIXED
2.0 S5 (4july)
blocking-b2g 2.0+
Tracking Status
b2g-v1.4 --- unaffected
b2g-v2.0 --- fixed
b2g-v2.1 --- fixed

People

(Reporter: ranbena, Assigned: kgrandon)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

46 bytes, text/x-github-pull-request
ranbena
: review+
Details | Review
STR:
1. Connect device to internet.
2. Long press homescreen and click "Add Smart Collection".
3. Once the list appears, return to home.
4. Disconnect from internet.
5. Do step #2.
6. Click on "Funny".
7. Wait till returned to homescreen.

Expected: A default icon labeled "Funny" is added to homescreen.
Actual: Nothing added to homescreen.
QA Wanted to compare behavior on 1.4 with the old e.me search.
QA Whiteboard: [VH-FL-blocking-][VH-FC-blocking?]
Keywords: qawanted
This path is doable on 1.4. Marked as blocker for parity with the previous version.
blocking-b2g: --- → 2.0?
QA Whiteboard: [VH-FL-blocking-][VH-FC-blocking?] → [VH-FL-blocking-][VH-FC-blocking+]
status-b2g-v2.1: --- → ?
Keywords: qawanted
Whiteboard: [systemsfe]
The offline collection experience is pretty bad on the new or old homescreen. If we support this we should support it from the very first context menu, and probably not in the middle of the flow.
I agree. We should simply have a connectivity message and abort the process.
blocking-b2g: 2.0? → 2.0+
Do we need approval from UX here?
Looping in UX/Product to make sure they are ok with it...

Guys - this is the case where we want to add smart collections, but lose connectivity to the internet after you have already viewed the smart collections list. We would like to simply show the same message that the user receives when they create the collection (it does not let them), instead of creating an empty smart collection.

Will that work for you for 2.0?
Flags: needinfo?(pdolanjski)
Flags: needinfo?(jsavory)
(In reply to Kevin Grandon :kgrandon from comment #6)
> Looping in UX/Product to make sure they are ok with it...
> 
> Guys - this is the case where we want to add smart collections, but lose
> connectivity to the internet after you have already viewed the smart
> collections list. We would like to simply show the same message that the
> user receives when they create the collection (it does not let them),
> instead of creating an empty smart collection.
> 
> Will that work for you for 2.0?

Works for me.
Flags: needinfo?(pdolanjski)
Yup, I agree with this as well.
Flags: needinfo?(jsavory)
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Target Milestone: --- → 2.0 S5 (4july)
Thanks guys. Renaming the bug to capture what the intended fix will be.
Summary: [Collection app] Can't create Collection when offline → [Collection app] Do not allow creation of smart collections while offline
Attached file Github pull request
Work in progress, test coming soon.
Comment on attachment 8446163 [details] [review]
Github pull request

Ran - could you take a look at this when you have a chance? Thanks!
Attachment #8446163 - Flags: review?(ran)
Comment on attachment 8446163 [details] [review]
Github pull request

LGTM. Though I would consider removing the Collection list caching as it now has no use.
Attachment #8446163 - Flags: review?(ran) → review+
Landed: https://github.com/mozilla-b2g/gaia/commit/605a6cc6795ab923dd7e4ea8db0a615dff71bb9f

Keeping caching of the list for now - maybe that speeds up future requests? But we can remove it down the road if it's just hurting us.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.