1029150 - Remove dangerous public destructor of nsCryptoRunnable

Status: RESOLVED FIXED

(Core :: DOM: Security, defect)

Description

[Benoit Jacob [:bjacob] (mostly away)]

In bug 1028588 we removed dangerous public destructors of XPCOM-refcounted classes outside of a finite whitelist, see HasDangerousPublicDestructor. Now we are going over the entries in this whitelist.

One of them is: nsCryptoRunnable

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Remove dangerous public destructor of nsCryptoRunnable.

Comment 2

[Andrew McCreight [:mccr8]]

try: https://tbpl.mozilla.org/?tree=Try&rev=daa327c18c40

Comment 3

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Comment on attachment 8464347 [details] [diff] [review]
Remove dangerous public destructor of nsCryptoRunnable.

Review of attachment 8464347 [details] [diff] [review]:
-----------------------------------------------------------------

Great - thanks for doing this.

::: security/manager/ssl/src/nsCrypto.cpp
@@ +2043,5 @@
>    if (!aJsCallback.IsVoid()) {
>      args->m_jsCallback = aJsCallback;
>    }
>  
> +  nsRefPtr<nsCryptoRunnable> cryptoRunnable = new nsCryptoRunnable(args);

This is something I don't know myself, but is it preferable to use the assignment operator or the constructor (like so: 'nsRefPtr<nsCryptoRunnable> cryptoRunnable(new nsCryptoRunnable(args));') in cases like this?

Comment 4

[Andrew McCreight [:mccr8]]

I changed it.

https://hg.mozilla.org/integration/mozilla-inbound/rev/06f72ed86256

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/06f72ed86256