Closed Bug 1029162 Opened 10 years ago Closed 10 years ago

tern info for global objects is incomplete, eg no document.query*

Categories

(DevTools :: Source Editor, defect)

Product:
DevTools
Component:
Source Editor
Version:
30 Branch
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 33

People

(Reporter: canuckistani, Assigned: bgrins)

References

Details

Attachments

(3 files, 1 obsolete file)

tern-query.gif
304.47 KB, image/gif
Details
tern-0.6.2.patch
45.10 KB, patch
past
: review+
Details | Diff | Splinter Review
tern-querySelector.patch
1.83 KB, patch
past
: review+
Details | Diff | Splinter Review
Attached image tern-query.gif —
The autocomplete list provided by tern for eg document or window is incomplete, for example I do not see querySelector or querySelectorAll when typing in: document.que ...and hitting ctrl+space ( see attached screencap )
The tern online demo page has the same issue, so I filed an upstream bug: https://github.com/marijnh/tern/issues/347
See Also: → https://github.com/marijnh/tern/issues/347
This was promptly fixed with: https://github.com/marijnh/tern/commit/7903a4edd0da055409acf0680b998a359c81d45a We'll get it in the next update. CCing Brian who is doing those.
Looks like 0.6.2 is out on 6/6/2014 (http://ternjs.net/) - probably worth an update. If I get this done before a new release is out we could update directly to the master browser.json to get the querySelector[All] fix.
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Attached patch tern-0.6.2.patch — — Splinter Review
Bumps tern from 0.5.1 to 0.6.2. Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=c03407eba0e5
Attachment #8445439 - Flags: review?(past)
Attached patch tern-doc-link.patch (obsolete) — — Splinter Review
Add querySelector[All] to docs
Attachment #8445441 - Flags: review?(past)
Comment on attachment 8445439 [details] [diff] [review] tern-0.6.2.patch Review of attachment 8445439 [details] [diff] [review]: ----------------------------------------------------------------- Funny how we use UPGRADING.md for acorn, pretty-fast, sourcemap and README for codemirror, tern, but oh well.
Attachment #8445439 - Flags: review?(past) → review+
Comment on attachment 8445441 [details] [diff] [review] tern-doc-link.patch Review of attachment 8445441 [details] [diff] [review]: ----------------------------------------------------------------- I'm confused: this patch is already applied, isn't it?
Attachment #8445441 - Flags: review?(past)
Sorry - that was the wrong patch
Attachment #8445441 - Attachment is obsolete: true
Attachment #8445811 - Flags: review?(past)
Attachment #8445811 - Flags: review?(past) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/13cf616f529e https://hg.mozilla.org/mozilla-central/rev/e709613cc827
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 33
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: