Closed
Bug 1029173
Opened 10 years ago
Closed 8 years ago
Clean up nsDataSignatureVerifier
Categories
(Core :: Security: PSM, defect)
Core
Security: PSM
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: briansmith, Assigned: Cykesiopka)
Details
(Whiteboard: [psm-assigned])
Attachments
(1 file)
See review comments in bug 1028643. nsDataSignatureVerifier needs to implement nsNSSShutDownObject.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → cykesiopka.bmo
Status: NEW → ASSIGNED
Whiteboard: [psm-assigned]
Assignee | ||
Updated•8 years ago
|
Summary: nsDataSignatureVerifier (nsIDataSignatureVerifier implementation) does not check for NSS shutdown before using NSS (nsNSSShutDownObject) → Clean up nsDataSignatureVerifier
Assignee | ||
Comment 1•8 years ago
|
||
This patch does the following: - Implements nsNSSShutDownObject. - Replaces more raw pointers with smart pointers. - Fixes other misc issues. Review commit: https://reviewboard.mozilla.org/r/45419/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/45419/
Attachment #8739896 -
Flags: review?(dkeeler)
Comment on attachment 8739896 [details] MozReview Request: Bug 1029173 - Clean up nsDataSignatureVerifier. r=keeler https://reviewboard.mozilla.org/r/45419/#review42457 LGTM.
Attachment #8739896 -
Flags: review?(dkeeler) → review+
Assignee | ||
Comment 3•8 years ago
|
||
Comment on attachment 8739896 [details] MozReview Request: Bug 1029173 - Clean up nsDataSignatureVerifier. r=keeler Review request updated; see interdiff: https://reviewboard.mozilla.org/r/45419/diff/1-2/
Attachment #8739896 -
Attachment description: MozReview Request: Bug 1029173 - Clean up nsDataSignatureVerifier. → MozReview Request: Bug 1029173 - Clean up nsDataSignatureVerifier. r=keeler
Assignee | ||
Comment 4•8 years ago
|
||
Thanks! https://treeherder.mozilla.org/#/jobs?repo=try&revision=eb6844c7e793b7f51bd7b99130c720c420366520
Keywords: checkin-needed
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2c9daa36cfd7
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•