Clean up nsDataSignatureVerifier

RESOLVED FIXED in Firefox 48

Status

()

Core
Security: PSM
RESOLVED FIXED
4 years ago
2 years ago

People

(Reporter: briansmith, Assigned: Cykesiopka)

Tracking

Trunk
mozilla48
Points:
---

Firefox Tracking Flags

(firefox48 fixed)

Details

(Whiteboard: [psm-assigned])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

See review comments in bug 1028643. nsDataSignatureVerifier needs to implement nsNSSShutDownObject.
(Assignee)

Updated

2 years ago
Assignee: nobody → cykesiopka.bmo
Status: NEW → ASSIGNED
Whiteboard: [psm-assigned]
(Assignee)

Updated

2 years ago
Summary: nsDataSignatureVerifier (nsIDataSignatureVerifier implementation) does not check for NSS shutdown before using NSS (nsNSSShutDownObject) → Clean up nsDataSignatureVerifier
(Assignee)

Comment 1

2 years ago
Created attachment 8739896 [details]
MozReview Request: Bug 1029173 - Clean up nsDataSignatureVerifier. r=keeler

This patch does the following:
 - Implements nsNSSShutDownObject.
 - Replaces more raw pointers with smart pointers.
 - Fixes other misc issues.

Review commit: https://reviewboard.mozilla.org/r/45419/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/45419/
Attachment #8739896 - Flags: review?(dkeeler)
Comment on attachment 8739896 [details]
MozReview Request: Bug 1029173 - Clean up nsDataSignatureVerifier. r=keeler

https://reviewboard.mozilla.org/r/45419/#review42457

LGTM.
Attachment #8739896 - Flags: review?(dkeeler) → review+
(Assignee)

Comment 3

2 years ago
Comment on attachment 8739896 [details]
MozReview Request: Bug 1029173 - Clean up nsDataSignatureVerifier. r=keeler

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/45419/diff/1-2/
Attachment #8739896 - Attachment description: MozReview Request: Bug 1029173 - Clean up nsDataSignatureVerifier. → MozReview Request: Bug 1029173 - Clean up nsDataSignatureVerifier. r=keeler
(Assignee)

Comment 4

2 years ago
Thanks!

https://treeherder.mozilla.org/#/jobs?repo=try&revision=eb6844c7e793b7f51bd7b99130c720c420366520
Keywords: checkin-needed

Comment 5

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/2c9daa36cfd7
Keywords: checkin-needed

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/2c9daa36cfd7
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.