Closed Bug 1029173 Opened 10 years ago Closed 8 years ago

Clean up nsDataSignatureVerifier

Categories

(Core :: Security: PSM, defect)

Product:
Core
Component:
Security: PSM
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla48
Tracking Flags:
Tracking Status
firefox48 --- fixed

People

(Reporter: briansmith, Assigned: Cykesiopka)

Details

(Whiteboard: [psm-assigned])

Attachments

(1 file)

MozReview Request: Bug 1029173 - Clean up nsDataSignatureVerifier. r=keeler
58 bytes, text/x-review-board-request
keeler
: review+
Details 
See review comments in bug 1028643. nsDataSignatureVerifier needs to implement nsNSSShutDownObject.
Assignee: nobody → cykesiopka.bmo
Status: NEW → ASSIGNED
Whiteboard: [psm-assigned]
Summary: nsDataSignatureVerifier (nsIDataSignatureVerifier implementation) does not check for NSS shutdown before using NSS (nsNSSShutDownObject) → Clean up nsDataSignatureVerifier
This patch does the following:
 - Implements nsNSSShutDownObject.
 - Replaces more raw pointers with smart pointers.
 - Fixes other misc issues.

Review commit: https://reviewboard.mozilla.org/r/45419/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/45419/
Attachment #8739896 - Flags: review?(dkeeler)
Comment on attachment 8739896 [details]
MozReview Request: Bug 1029173 - Clean up nsDataSignatureVerifier. r=keeler

https://reviewboard.mozilla.org/r/45419/#review42457

LGTM.
Attachment #8739896 - Flags: review?(dkeeler) → review+
Comment on attachment 8739896 [details]
MozReview Request: Bug 1029173 - Clean up nsDataSignatureVerifier. r=keeler

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/45419/diff/1-2/
Attachment #8739896 - Attachment description: MozReview Request: Bug 1029173 - Clean up nsDataSignatureVerifier. → MozReview Request: Bug 1029173 - Clean up nsDataSignatureVerifier. r=keeler
https://hg.mozilla.org/mozilla-central/rev/2c9daa36cfd7
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: