Closed Bug 1029195 Opened 7 years ago Closed 7 years ago

Nodes in graph lose focus during redraw

Categories

(DevTools Graveyard :: Web Audio Editor, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 33

People

(Reporter: jsantell, Assigned: jsantell)

References

Details

Attachments

(1 file, 2 obsolete files)

When an event occurs, like a new connection, a new node created, or destroyed, the graph in the web audio editor gets redrawn. If I have a node selected (and appears highlighted), the inspector opens up -- on a redraw, the inspector remains open, but the node I had selected no longer is highlighted.
Assignee: nobody → jsantell
Attached patch 1029195-wae-graph-rerender.patch (obsolete) — Splinter Review
Attachment #8445271 - Flags: review?(vporof)
Comment on attachment 8445271 [details] [diff] [review]
1029195-wae-graph-rerender.patch

Review of attachment 8445271 [details] [diff] [review]:
-----------------------------------------------------------------

Happy to see so many tests.

::: browser/devtools/webaudioeditor/test/browser_wa_graph-render-03.js
@@ +23,5 @@
> +  ok(findGraphNode(panelWin, nodeIDs[1]).classList.contains("selected"),
> +    "Node selected once.");
> +
> +  yield once(panelWin, EVENTS.UI_GRAPH_RENDERED);
> +  

Nit: whitespace.
Attachment #8445271 - Flags: review?(vporof) → review+
Attached patch 1029195-wae-graph-rerender.patch (obsolete) — Splinter Review
Nits fixed
Attachment #8445271 - Attachment is obsolete: true
Attachment #8447339 - Flags: review+
Status: NEW → ASSIGNED
Rebase after bug 1026576
Keywords: checkin-needed
Rebased and good to go
Attachment #8447339 - Attachment is obsolete: true
Attachment #8448099 - Flags: review+
https://hg.mozilla.org/integration/fx-team/rev/1b526b761337
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/1b526b761337
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 33
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.