1029195 - Nodes in graph lose focus during redraw

Status: RESOLVED FIXED

(DevTools Graveyard :: Web Audio Editor, defect)

Description

[Jordan Santell [:jsantell] [@jsantell]]

When an event occurs, like a new connection, a new node created, or destroyed, the graph in the web audio editor gets redrawn. If I have a node selected (and appears highlighted), the inspector opens up -- on a redraw, the inspector remains open, but the node I had selected no longer is highlighted.

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1029195-wae-graph-rerender.patch

Comment 2

[Victor Porof [:vporof][:vp]]

Comment on attachment 8445271 [details] [diff] [review]
1029195-wae-graph-rerender.patch

Review of attachment 8445271 [details] [diff] [review]:
-----------------------------------------------------------------

Happy to see so many tests.

::: browser/devtools/webaudioeditor/test/browser_wa_graph-render-03.js
@@ +23,5 @@
> +  ok(findGraphNode(panelWin, nodeIDs[1]).classList.contains("selected"),
> +    "Node selected once.");
> +
> +  yield once(panelWin, EVENTS.UI_GRAPH_RENDERED);
> +  

Nit: whitespace.

Comment 3

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1029195-wae-graph-rerender.patch

Nits fixed

Comment 4

[Jordan Santell [:jsantell] [@jsantell]]

https://tbpl.mozilla.org/?tree=Try&rev=ed92577f0958

Comment 5

[Jordan Santell [:jsantell] [@jsantell]]

Rebase after bug 1026576

Comment 6

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1029195-wae-graph-rerender.patch

Rebased and good to go

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/1b526b761337

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1b526b761337