1029201 - Large app icons are 284px, not 289px

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Jim Porter (:squib)]

For some reason, the largest app icons are all labeled as being 289px in their filenames and in the manifests. They are, in fact, 284px. We should probably fix this.

References:

apps/sms/manifest.webapp
45:    "289": "/style/icons/sms_289.png"

apps/wallpaper/manifest.webapp
47:    "289": "/style/icons/wallpaper_289.png"

apps/costcontrol/manifest.webapp
50:  "289": "/style/icons/costcontrol_289.png"

apps/music/manifest.webapp
61:    "289": "/style/icons/music_289.png"

apps/communications/manifest.webapp
19:        "289": "/dialer/style/icons/dialer_289.png"
48:        "289": "/contacts/style/icons/contacts_289.png"

apps/clock/manifest.webapp
41:    "289": "/style/icons/clock_289.png"

apps/browser/manifest.webapp
48:    "289": "/shared/resources/branding/browser_289.png"

apps/video/manifest.webapp
44:    "289": "/style/icons/video_289.png"

apps/calendar/manifest.webapp
47:    "289": "/style/icons/calendar_289.png"

apps/callscreen/manifest.webapp
36:    "289": "/style/icons/dialer_289.png"

apps/email/manifest.webapp
48:    "289": "/style/icons/email_289.png"

apps/fm/manifest.webapp
40:    "289": "/style/icons/fm_289.png"

apps/gallery/manifest.webapp
68:    "289": "/style/icons/gallery_289.png"

apps/settings/manifest.webapp
82:    "289": "/style/icons/settings_289.png"

apps/camera/manifest.webapp
61:    "289": "/style/icons/camera_289.png"

Comment 1

[Tiffanie Shakespeare [:tif]]

Is this something you can help with? This was filed because of comment#20 in Bug 1020588

Comment 2

[Jim Porter (:squib)]

Taking this since it's easy to automate.

Comment 3

[Jim Porter (:squib)]

Attachment: Fix it

Comment 4

[Jim Porter (:squib)]

Comment on attachment 8444935 [details] [review]
Fix it

Yuren, do you think you could look at this? It's sort of build system related...

I did everything via some shell commands, which are listed in the PR.

Comment 5

[Jim Porter (:squib)]

Comment on attachment 8444935 [details] [review]
Fix it

Switching r? to Kevin Grandon...

Comment 6

[Kevin Grandon :kgrandon]

Comment on attachment 8444935 [details] [review]
Fix it

Seems to work for me, thanks!

Comment 7

[Jim Porter (:squib)]

Landed: https://github.com/mozilla-b2g/gaia/commit/6bd60af83260095768e703233b9bac8239d22db3

Comment 8

[Jim Porter (:squib)]

Comment on attachment 8444935 [details] [review]
Fix it

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): bug 1014591
[User impact] if declined: Not sure; icons might be slightly off in scale?
[Testing completed]: Manually tested with all apps
[Risk to taking this patch] (and alternatives if risky): Low risk, just moves some files around (and I did this via a script to avoid any typos)
[String changes made]: None

Comment 9

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Thanks guys :)

Comment 10

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/8ef9bba63381da2dad36ac5a1468f81f4f2ce8ff