Closed Bug 1029204 Opened 6 years ago Closed 6 years ago

|mach valgrind-test|: add a timeout

Categories

(Testing :: General, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla33

People

(Reporter: njn, Assigned: njn)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

In bug 948145 we're seeing various kinds of timeouts in the Valgrind test job. The goal of this bug is to distinguish timeouts that occur while Valgrind itself is running (as opposed to hg running during setup, for example).
This works, but I'm not entirely happy with it. On my fast linux box the
valgrind test takes about 5 minutes, so a timeout of 1100 seconds (18.33
minutes) isn't all that high. 

I put the timeout on the wait() call rather so that I could distinguish
timeouts (which don't cause |exitcode| to be set) from other kinds of premature
failures. If I put the timeout on the run() call I didn't seem to be able to do
that.

ted, any suggestions on other ways to do this are welcome.
Attachment #8444779 - Flags: review?(ted)
Blocks: 778688
Comment on attachment 8444779 [details] [diff] [review]
|mach valgrind-test|: add a timeout

Review of attachment 8444779 [details] [diff] [review]:
-----------------------------------------------------------------

::: build/valgrind/mach_commands.py
@@ +143,5 @@
>                  errs = outputHandler.error_count
>                  supps = outputHandler.suppression_count
>                  if errs != supps:
>                      status = 1  # turns the TBPL job orange
> +                    print('TEST-UNEXPECTED-FAIL | valgrind-test | error parsing:', errs, "errors seen, but", supps, "generated suppressions seen")

it's a bit more conventional python to use string interpolation, like:
'... but %d generated suppressions seen" % supps) (here and below).

@@ +152,5 @@
>                  else:
>                      status = 1  # turns the TBPL job orange
>                      # We've already printed details of the errors.
>  
> +                if exitcode == None: 

nit: trailing whitespace.
Attachment #8444779 - Flags: review?(ted) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/e08b171b9a02

I ended up using format() for the string interpolation, since % is deprecated in Python 3.
https://hg.mozilla.org/mozilla-central/rev/e08b171b9a02
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.